fix: remove gap between tabs and list

[alex-golovanov]

Description

Remove a small gap that revealed a slice of action bar.

Fixes #37220

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11688613194
Commit: 87b7ed8
Cypress dashboard.
Tags: @tag.IDE
Spec:

---

Tue, 05 Nov 2024 17:13:44 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Style
  • Updated the positioning and padding of the List component for improved layout.
  • Adjusted the styling of the ListContainer for better visual alignment.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the List component located in app/client/src/pages/Editor/IDE/EditorTabs/List.tsx. The primary modification involves updating the ListContainer styled component to adjust its CSS properties, specifically changing its positioning and padding. The previous class string for positioning has been removed, while other properties, including rendering logic, remain unchanged.

Changes

File Path	Change Summary
app/client/src/pages/Editor/IDE/EditorTabs/List.tsx	Updated ListContainer CSS properties: added position: absolute, top: 32px, padding-top: 4px; removed previous class string "absolute top-[36px]".

Assessment against linked issues

Objective	Addressed	Explanation
Fix the problem with toolbar visibility in list view mode (1px gap) (#37220)	✅

Possibly related PRs

• fix: Add & list tabs padding fixes #35057: This PR modifies the List.tsx file, which is directly related to the List component in the main PR, focusing on layout adjustments that may impact the visual representation of the component.
• fix: Tabs icon alignment #35059: Although this PR primarily addresses the FileTab.tsx, it involves changes to tab-related components, which could be relevant to the overall UI adjustments in the List component as both are part of the tabbed interface.
• fix: Tabs UI updates #33536: This PR includes updates to the Container.tsx and FileTabs.tsx, which are part of the same tabbed interface as the List component, indicating a potential connection in UI updates across these components.

Suggested labels

Bug, Task, IDE Pod, IDE Navigation, ok-to-test

Suggested reviewers

• hetunandu
• ankitakinger

🎉 In the land of code where changes flow,
The List now dances, with a new CSS glow!
Absolute and tidy, it stands with grace,
Adjusting its padding, it finds its place.
With toolbar visibility now in sight,
The UI shines brighter, a true delight! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alex-golovanov]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11684792007.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37242.
recreate: .

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/client/src/pages/Editor/IDE/EditorTabs/List.tsx (1)

11-13: Consider using CSS custom properties for consistency.

Since this is a UI spacing value that might need adjustment across different components, consider using a CSS custom property.

-  top: 32px;
-  padding-top: 4px;
+  top: var(--ads-list-top-spacing, 32px);
+  padding-top: var(--ads-list-padding-top, 4px);

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between db713e9 and 87b7ed8.

📒 Files selected for processing (1)

• app/client/src/pages/Editor/IDE/EditorTabs/List.tsx (1 hunks)

🔇 Additional comments (1)

app/client/src/pages/Editor/IDE/EditorTabs/List.tsx (1)

11-13: Verify the gap fix implementation.

The change from Tailwind's top-[36px] to top: 32px with padding-top: 4px maintains the same total spacing but might provide better control over the gap. However, we should verify this fixes the 1px gap issue completely.

Let's check if there are similar gap issues elsewhere:

✅ Verification successful

Let me search for similar toolbar/list gap implementations to verify this change.

---

Gap fix implementation looks correct

The change from Tailwind's top-[36px] to top: 32px with padding-top: 4px maintains the same total spacing (36px) while providing better control over the gap. The implementation is consistent within the file and there are no other similar patterns that need adjustment.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for similar toolbar/list gap implementations
rg -l "top-\[\d+px\]" --type ts --type tsx | xargs rg "toolbar|list" -l

Length of output: 65093

---

Script:

#!/bin/bash
# Search for similar toolbar/list gap implementations in the specific file and related components
rg -A 3 -B 3 "top-\[\d+px\]|top:\s*\d+px" "app/client/src/pages/Editor/IDE/EditorTabs/List.tsx" "app/client/src/pages/Editor/IDE/EditorTabs/"

Length of output: 1366

[github-actions]

Deploy-Preview-URL: https://ce-37242.dp.appsmith.com