-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added JSON files linting check #35379
chore: added JSON files linting check #35379
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 68 files out of 165 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Failed server tests
|
Closing with ref to #35395 |
Description
This PR adds the spotless formatter and validator for the JSON files present in the project. If there is any invalid JSON file, the formatter fails and logs the file and the error LOC to be fixed.
Since Spotless is already added to the pre-commit hook it also makes it necessary to fix the JSON and then commit the changes.
Screenshot of the errors displayed for Invalid JSONs
Why is this Important?
All of our datasource forms appear on the UI from the JSON configuration files in the plugins. If an Invalid JSON is added, it can break the datasource usage experience for the users.
One such instance happened in the past, where due to a JSON formatting error, the users could not use Smart Substitution feature on production.
Reference
Fixes #34969
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?