Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: width of tooltip box is larger than text on the property panel #35734

Conversation

ALOK9442
Copy link
Contributor

@ALOK9442 ALOK9442 commented Aug 16, 2024

#32078

Description

Changes the width of tooltip container from full to fit-content
Checked it in different screen as well
Screenshot (274)

Fixes #32078

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Updated the styling of the PropertyHelpLabel for a more compact layout within the PropertyControl component, improving visual appeal and responsiveness.

Copy link
Contributor

coderabbitai bot commented Aug 16, 2024

Walkthrough

The recent updates to the PropertyControl component focus on enhancing the presentation of the PropertyHelpLabel. By changing its className from "w-full" to "fit-content", the label now adapts its width to match its content size, addressing issues related to tooltip box widths being larger than the text in the property pane. This change is aimed at creating a more refined and visually appealing layout.

Changes

Files Change Summary
app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx Modified className of PropertyHelpLabel from "w-full" to "fit-content" for improved tooltip width.

Assessment against linked issues

Objective Addressed Explanation
Width of tooltip box is larger than text ( #32078 )

🌟 In the realm where tooltips dwell,
A change was made, and all is well.
From full-width stretch to fit just right,
Compact and neat, a pure delight!
User's view now shines so bright! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between db9d572 and 560082a.

Files selected for processing (1)
  • app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx (1 hunks)
Additional comments not posted (1)
app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx (1)

978-978: Good change! Verify UI consistency across screen sizes.

The change from "w-full" to "fit-content" for the PropertyHelpLabel className should help the tooltip align better with its content. Please ensure that this adjustment maintains layout consistency across various screen sizes and does not introduce any unexpected UI issues.

@ALOK9442
Copy link
Contributor Author

I have verified the ui consistency for all screen sizes
@Nikhil-Nandagopal could u please look into it and give approval?

Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Aug 24, 2024
Copy link

This PR has been closed because of inactivity.

@nidhi-nair nidhi-nair merged commit f02b448 into appsmithorg:release Sep 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Width of tooltip box is larger than text on the property pane
4 participants