Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: external merge request from Contributor #36045

Conversation

rahulbarwal
Copy link
Contributor

@rahulbarwal rahulbarwal commented Sep 2, 2024

Description

Fixes #35734

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10663820810
Commit: 442b111
Cypress dashboard.
Tags: @tag.All
Spec:


Mon, 02 Sep 2024 10:12:29 UTC

@rahulbarwal rahulbarwal requested a review from a team as a code owner September 2, 2024 08:31
@rahulbarwal rahulbarwal self-assigned this Sep 2, 2024
Copy link
Contributor

coderabbitai bot commented Sep 2, 2024

Walkthrough

The modification involves changing the className of the PropertyHelpLabel component within the PropertyControl functional component from "w-full" to "fit-content". This adjustment alters the width behavior of the tooltip box, allowing it to fit the content size rather than occupying the full width available.

Changes

File Path Change Summary
app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx Updated className of PropertyHelpLabel from "w-full" to "fit-content" for improved layout.

Assessment against linked issues

Objective Addressed Explanation
Fix tooltip box width to fit content (#32078)

🎉 In the realm of code, a change so bright,
The tooltip now fits, a beautiful sight!
No more wide boxes, just snug and neat,
With content embraced, it’s truly a treat.
A little tweak brings joy to the view,
Hooray for the change, we celebrate you! 🎊


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 2, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e501413 and 442b111.

Files selected for processing (1)
  • app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx

@rahulbarwal rahulbarwal added ok-to-test Required label for CI Widgets & Accelerators Pod Issues related to widgets & Accelerators and removed ok-to-test Required label for CI labels Sep 2, 2024
@rahulbarwal
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

github-actions bot commented Sep 2, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10663871669.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36045.
recreate: .

Copy link

github-actions bot commented Sep 2, 2024

Deploy-Preview-URL: https://ce-36045.dp.appsmith.com

@ALOK9442
Copy link
Contributor

ALOK9442 commented Sep 2, 2024

hey @rahulbarwal, i did the same changes and you also committed the same change, is it going to make any difference? just curios if yes then I would love to know about it

@rahulbarwal
Copy link
Contributor Author

closing as no longer needed

@rahulbarwal rahulbarwal closed this Sep 3, 2024
@rahulbarwal
Copy link
Contributor Author

Hey @ALOK9442 ,
This PR is just for running all the CI that does not run with your(external) PRs. Rest assured, once we have everything passing, we merge yours and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Widgets & Accelerators Pod Issues related to widgets & Accelerators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants