feat: Action redesign: Updating the config for Google sheets plugin to use sections and zones format #36117
Conversation
WalkthroughThe changes involve significant updates to the Google Sheets plugin and related components, focusing on enhancing the structure and functionality of the control configurations. Key modifications include the introduction of new control types, restructuring of child elements into zones, and updates to CSS for improved styling. These adjustments aim to streamline the user interface and improve the organization of controls without altering the core functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Plugin
User->>UI: Interacts with Google Sheets Plugin
UI->>Plugin: Sends configuration request
Plugin-->>UI: Returns updated control structure
UI->>User: Displays enhanced controls and options
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/build-deploy-preview skip-tests=true |
github-actions
bot
added
IDE Navigation
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10698991061. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (7)
- app/client/src/components/formControls/DynamicInputTextControl.tsx (1 hunks)
- app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/delete.json (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/fetch_many.json (3 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/insert.json (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/root.json (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/update.json (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/src/components/formControls/DynamicInputTextControl.tsx
Additional comments not posted (19)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/delete.json (2)
2-2: Verify the impact of updating thecontrolTypeto"SECTION_V2".The
controlTypehas been updated from"SECTION"to"SECTION_V2", which suggests a shift to a new version of the section control.Please ensure that this change does not introduce any breaking changes or unexpected behavior in the plugin's functionality. Consider running tests to validate the plugin's behavior with the updated
controlType.
9-21: Great work on restructuring thechildrenelements!The introduction of the parent object with
controlType: "DOUBLE_COLUMN_ZONE"andidentifier: "DELETE-Z1"enhances the organization and presentation of the child components within the section. The child element retains its original properties, ensuring that the core functionality remains intact.app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (1)
51-53: Great work on enhancing the styling flexibility for dynamic input text controls! 👍The changes you made to remove the minimum height and width constraints for the
.uqi-dynamic-input-textclass are a good temporary solution to address the ongoing issue with the minimum width of the code editor in theDynamicTextFieldControl.Using the
!importantpriority ensures that these styles override any other conflicting styles applied to the element. This will provide more flexibility in sizing the dynamic input text controls until the underlying issue is resolved.Just remember to revisit this workaround once the code editor's minimum width issue is fixed, as indicated by the comment. Keep up the great work! 🌟
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/update.json (4)
5-5: Great work on refining the conditional logic!The change ensures that the control is only displayed when the required data is available, improving the user experience.
7-8: Nice addition of thelabelanddescriptionproperties!These properties will help users better understand the purpose and functionality of the control.
2-2: Verify the impact of changing thecontrolTypetoSECTION_V2.Ensure that the change does not break any existing functionality and is compatible with the rest of the codebase.
Run the following script to verify the usage of
SECTION_V2:
11-12: Verify the impact of changing thecontrolTypetoSINGLE_ZOLUMN_ZONE.Ensure that the change aligns with the overall design and functionality of the plugin.
Run the following script to verify the usage of
SINGLE_ZOLUMN_ZONE:app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/insert.json (3)
2-2: Great work updating thecontrolTypetoSECTION_V2! 👍This change aligns with the goal of enhancing the structure and functionality of the control configurations. The new version of the section control may offer improved features and capabilities.
9-24: Excellent job restructuring the "Spreadsheet Name" input within the newDOUBLE_COLUMN_ZONEcontrol type! 🎉This change enhances the logical grouping of controls and improves the overall organization of the configuration. By nesting related inputs within the new layout, you've made the interface more intuitive and user-friendly. Keep up the great work!
27-28: Fantastic job introducing theSINGLE_COLUMN_ZONEcontrol type for the "Row objects"! 🙌This change contributes to the overall goal of creating a more flexible and visually structured configuration. By organizing the "Row objects" within the new control type, you've enhanced the modularity and readability of the layout. Well done!
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/fetch_many.json (4)
9-39: Verify the user experience impact of introducing theDOUBLE_COLUMN_ZONEcontrol.Ensure that this change enhances the user experience and doesn't introduce any usability issues. Consider the following:
- Is the new layout intuitive and easy to navigate?
- Are the UI elements properly aligned and styled within the new control?
- Does the change introduce any accessibility concerns?
Manually test the UI changes to ensure a smooth user experience. Provide feedback on any usability issues encountered.
42-75: Verify the functionality of the redefinedCell rangeoption.Ensure that the
Cell rangeoption functions as expected with the new property name and tooltip text. Consider the following:
- Test various cell range inputs to ensure proper filtering of data.
- Verify that the tooltip text accurately describes the purpose and usage of the option.
Provide test cases and expected results for the
Cell rangeoption. Report any discrepancies or errors encountered.Additionally, update the documentation to reflect the changes made to the
Filter Formatsection and the redefinedCell rangeoption.
Line range hint
78-143: Verify the impact of the changes on theRows Sectionfunctionality.Ensure that the reorganization of the
Filter By,Sort By, and pagination sections within the newSINGLE_COLUMN_ZONEcontrols doesn't alter the core functionality. Consider the following:
- Test the filtering, sorting, and pagination features to ensure they work as expected.
- Verify that the new layout improves the readability and maintainability of the configuration.
Provide test cases and expected results for the
Rows Sectionfunctionality. Report any discrepancies or errors encountered.Additionally, monitor the performance of the
Rows Sectionafter the changes to ensure there are no significant performance implications due to the reorganization.Also applies to: 145-162, 164-190
2-2: Verify the impact of changing thecontrolTypetoSECTION_V2.Ensure that this change is consistently applied across the codebase and doesn't introduce any breaking changes.
Run the following script to verify the usage of
SECTION_V2:app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/root.json (5)
8-10: Verify the rendering and handling of the "DOUBLE_COLUMN_ZONE" control type.The introduction of the "DOUBLE_COLUMN_ZONE" control type suggests an improvement in the organization and presentation of the user interface. It's crucial to verify that the application properly renders and handles this new control type to ensure the desired layout is achieved.
To verify this, please follow these steps:
- Run the application and navigate to the Google Sheets plugin configuration interface.
- Inspect the rendered layout and ensure that the child elements are organized into a double-column layout as intended by the "DOUBLE_COLUMN_ZONE" control type.
- Interact with the elements within the double-column zone and confirm that they behave as expected.
If the layout appears as intended and the elements function correctly, it indicates that the application properly supports the "DOUBLE_COLUMN_ZONE" control type. If any issues are observed, further investigation and fixes may be necessary.
12-49: Verify the functionality and behavior of the reformatted "Operation" dropdown.The "Operation" dropdown has been reformatted to improve clarity and presentation. It's essential to ensure that the reformatting does not introduce any unintended changes to the functionality or behavior of the dropdown.
To verify this, please perform the following tests:
- Open the Google Sheets plugin configuration interface and locate the "Operation" dropdown.
- Interact with the dropdown and ensure that all the expected options are present and selectable.
- Select each option one by one and verify that the corresponding functionality is triggered correctly.
- Confirm that the selected option is properly reflected in the application's state and any related UI elements.
If the dropdown functions as expected and the reformatting has not introduced any issues, then the changes can be considered safe. If any anomalies or unexpected behaviors are observed, further investigation and fixes may be required.
52-77: Verify the conditional logic and dependencies of the reformatted "Entity" dropdown.The "Entity" dropdown has been reformatted to enhance clarity and presentation while preserving its properties, options, and conditional logic. It's crucial to verify that the reformatting maintains the existing conditional logic and dependencies based on the selected operation.
To verify this, please perform the following tests:
- Open the Google Sheets plugin configuration interface and locate the "Entity" dropdown.
- Select different options in the "Operation" dropdown and observe the behavior of the "Entity" dropdown.
- Ensure that the options in the "Entity" dropdown are enabled or disabled based on the selected operation, as defined by the conditional logic.
- Verify that the selected entity type is properly reflected in the application's state and any related UI elements.
- Confirm that the dropdown's behavior aligns with the conditions specified in the
disabledproperties of each option.If the "Entity" dropdown exhibits the expected conditional behavior and dependencies based on the selected operation, then the reformatting can be considered successful. If any discrepancies or unexpected behaviors are observed, further investigation and fixes may be necessary.
86-154: Thoroughly test the functionality of the "Entity Selector" with the updated schema.The schema for the "Entity Selector" has been restructured to enhance its functionality and behavior. It's crucial to perform comprehensive testing to ensure that the "Entity Selector" functions as intended with the updated schema.
To thoroughly test the "Entity Selector," please follow these steps:
- Open the Google Sheets plugin configuration interface and locate the "Entity Selector" section.
- Test the "Spreadsheet" dropdown:
- Verify that the dropdown is populated with the expected options from the user's Google Drive.
- Select a spreadsheet and ensure that the selection is properly reflected in the application's state.
- Test the "Sheet name" dropdown:
- Verify that the dropdown is populated with the sheets from the selected spreadsheet.
- Select a sheet and ensure that the selection is properly reflected in the application's state.
- Confirm that the dropdown is shown or hidden based on the conditions specified in the
showproperty.- Test the "Table heading row index" input:
- Enter valid and invalid values and verify that the input validates the entered data correctly.
- Confirm that the input is shown or hidden based on the conditions specified in the
showproperty.- Test the interaction between the dropdowns and the "Table heading row index" input:
- Verify that the options in the dropdowns and the visibility of the input are updated dynamically based on the user's selections and the specified conditions.
Perform these tests with different combinations of operations and entity types to cover all possible scenarios. If the "Entity Selector" functions as expected and the updated schema does not introduce any issues, then the changes can be considered reliable. If any bugs or unexpected behaviors are encountered, further investigation and fixes may be required.
4-4: Verify the support and benefits of the "SECTION_V2" control type.The
controlTypefor the main section has been updated from "SECTION" to "SECTION_V2". It's crucial to ensure that the application fully supports the "SECTION_V2" control type and that it provides the intended enhancements over the previous "SECTION" type.To verify this, please run the following script:
This script searches for references to the "SECTION_V2" control type in the application's TypeScript and JavaScript files. If references are found, it indicates that the application likely supports this control type. If no references are found, further investigation may be necessary to ensure proper support and functionality.
Verification successful
Let's try a different approach to ensure we thoroughly check for the "SECTION_V2" control type across the entire codebase. We'll search without specifying file types to avoid the previous issue. This will help us determine if "SECTION_V2" is supported or referenced anywhere in the code.
The "SECTION_V2" control type is supported and integrated into the application.
The search results show that "SECTION_V2" is referenced in both client-side and server-side files, indicating that it is indeed supported and used across various configurations. This suggests that the application is equipped to handle this control type effectively.
- Client-side Reference: Found in
app/client/src/pages/Editor/QueryEditor/FormRender.tsx.- Server-side References: Found in multiple JSON configuration files related to plugins.
This confirms that the transition from "SECTION" to "SECTION_V2" is well-supported within the codebase. Keep up the good work in ensuring compatibility and enhancements!
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the application code references the "SECTION_V2" control type if rg --type typescript --type javascript 'SECTION_V2' > /dev/null; then echo "The application code references the 'SECTION_V2' control type." else echo "The application code does not reference the 'SECTION_V2' control type. Further investigation is needed." fiLength of output: 309
Script:
#!/bin/bash # Search for references to "SECTION_V2" across all files in the codebase rg 'SECTION_V2' || echo "No references to 'SECTION_V2' found in the codebase."Length of output: 1026
|
Deploy-Preview-URL: https://ce-36117.dp.appsmith.com |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10713324884. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- app/client/src/components/formControls/SortingControl.tsx (1 hunks)
- app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/fetch_many.json (3 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/root.json (2 hunks)
Files skipped from review due to trivial changes (1)
- app/client/src/components/formControls/SortingControl.tsx
Files skipped from review as they are similar to previous changes (2)
- app/client/src/pages/Editor/ActionForm/Zone/styles.module.css
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/root.json
Additional comments not posted (5)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/fetch_many.json (5)
2-2: Updated control type toSECTION_V2.This change aligns with the PR's objective to enhance the structure and usability of the plugin's interface. The new
SECTION_V2likely offers improved capabilities or structure over the previous version.
9-41: Introduction ofDOUBLE_COLUMN_ZONEfor better layout organization.The new
DOUBLE_COLUMN_ZONEatFETCH_MANY-Z1is designed to improve the layout and organization of UI components. This change is part of the broader effort to enhance user experience by making the interface more intuitive and structured.
44-79: Enhanced filter format section within anotherDOUBLE_COLUMN_ZONE.The restructuring under
FETCH_MANY-Z2includes a more detailed filter format section, which now supports both "Where Clause" and "Cell range" options. This enhancement should provide users with clearer and more flexible filtering capabilities, aligning with the goal of improving the plugin's usability.
Line range hint
84-149: Single column zones for specialized sections.The introduction of
SINGLE_COLUMN_ZONEatROWS-SECTION-Z2and subsequent zones is a strategic design choice to segregate different functionalities clearly. Each zone is dedicated to specific aspects like filtering and sorting, which should help in maintaining a clean and organized UI.
Line range hint
152-176: Continued use ofSINGLE_COLUMN_ZONEfor additional sorting and pagination functionalities.The continued use of
SINGLE_COLUMN_ZONEinROWS-SECTION-Z3andROWS-SECTION-Z4for sorting and pagination reflects a consistent approach to UI design in the plugin. This consistency is crucial for user familiarity and ease of use.
|
Deploy-Preview-URL: https://ce-36117.dp.appsmith.com |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10714320172. |
|
Deploy-Preview-URL: https://ce-36117.dp.appsmith.com |
…o action-redesign/gsheets
ankitakinger
force-pushed
the
action-redesign/gsheets
branch
from
c0e6829
to
2fd8ef8
Compare
…o action-redesign/gsheets
…o action-redesign/gsheets
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10771923892. |
|
Deploy-Preview-URL: https://ce-36117.dp.appsmith.com |
…o action-redesign/gsheets
…o action-redesign/gsheets
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10805238144. |
|
Deploy-Preview-URL: https://ce-36117.dp.appsmith.com |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10810588299. |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/entity_data.json (2)
43-66: The spreadsheet URL dropdown control looks good! 🙌The dropdown control provides a convenient way for users to select the spreadsheet they want to work with. The conditional display based on the selected entity type and command ensures that the control is only shown when relevant, reducing clutter and confusion.
The dynamic value fetching is a great feature that populates the available options based on the user's spreadsheets, making it easy for them to select the desired spreadsheet.
One suggestion for improvement:
Consider adding a placeholder text to the dropdown control to provide a hint or example of the expected spreadsheet URL format. This can help users understand what kind of value they should enter.
You can add the
placeholderTextproperty to the control object with a suitable value, like this:{ "label": "Spreadsheet", "tooltipText": "The URL of the spreadsheet in your Google Drive", "propertyName": "rows_get_spreadsheetUrl", "configProperty": "actionConfiguration.formData.sheetUrl.data", "controlType": "DROP_DOWN", "isSearchable": true, "isRequired": true, + "placeholderText": "https://docs.google.com/spreadsheets/d/xyz/edit#gid=0", "fetchOptionsConditionally": true, "alternateViewTypes": ["json"], "conditionals": { ... } }This will provide a visual cue to users about the expected format of the spreadsheet URL.
93-104: The table heading row index control is a useful addition! 🎉The text input control allows users to specify the row index that contains the table headings in the selected sheet. This flexibility is important as different spreadsheets may have different structures and layouts.
The conditional display based on the selected entity type, command, and sheet name ensures that the control is only shown when it is applicable, keeping the form streamlined and relevant.
The initial value of "1" provides a reasonable default for the table heading row index, as it is a common convention for the first row to contain the headings.
One suggestion for improvement:
Consider adding validation to ensure that the entered value is a positive integer. You can achieve this by adding a "validation" property to the control object with a suitable regular expression pattern, like this:
{ "label": "Table heading row index", "tooltipText": "The index of the column names in the sheet (starts from 1)", "propertyName": "rows_get_tableHeadingRowIndex", "configProperty": "actionConfiguration.formData.tableHeaderIndex.data", "controlType": "QUERY_DYNAMIC_INPUT_TEXT", "initialValue": "1", "isRequired": true, + "validation": "^[1-9]\\d*$", "conditionals": { "show": "{{ new Object({ 'SPREADSHEET': [], 'SHEET': [], 'ROWS': ['INSERT_ONE', 'UPDATE_ONE', 'DELETE_ONE', 'FETCH_MANY', 'INSERT_MANY', 'UPDATE_MANY'] })[actionConfiguration.formData.entityType.data].includes(actionConfiguration.formData.command.data) && !!actionConfiguration.formData.sheetName.data }}" } }The regular expression pattern
^[1-9]\\d*$ensures that the entered value starts with a non-zero digit and can be followed by any number of digits. This validation will prevent users from entering invalid or negative values for the table heading row index.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/entity_data.json (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/fetch_many.json (1 hunks)
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/root.json (1 hunks)
Additional comments not posted (11)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/root.json (4)
4-4: Verify the support and functionality of the new "SECTION_V2" control type.The
controlTypefor the main section has been updated from "SECTION" to "SECTION_V2". This change suggests an upgrade to the handling of this component.Please ensure that:
- The application properly supports the "SECTION_V2" control type.
- The new control type provides the intended enhancements and does not introduce any unexpected behavior.
8-10: Verify the implementation and rendering of the "DOUBLE_COLUMN_ZONE" control type.A new control type "DOUBLE_COLUMN_ZONE" has been introduced to organize the layout of child elements. This change aims to enhance the structure and presentation of the editor interface.
Please ensure that:
- The "DOUBLE_COLUMN_ZONE" control type is properly implemented in the application.
- The child elements are correctly rendered within this new control type, maintaining the intended layout and functionality.
12-49: Verify the functionality of the reformatted "Operation" dropdown.The "Operation" dropdown has been reformatted to improve clarity and presentation while preserving its properties and options.
Please ensure that:
- The dropdown continues to function as expected after the reformatting.
- The options and their associated values remain intact and trigger the appropriate actions when selected.
56-62: Verify the existence and contents of the referenced JSON files.The "files" array has been updated with new JSON file references, suggesting changes to the associated configurations used by the plugin.
Please ensure that:
- The referenced JSON files (
entity_data.json,insert.json,delete.json,fetch_many.json, andupdate.json) exist in the expected locations.- The contents of these JSON files align with the intended configurations and do not introduce any inconsistencies or errors.
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/entity_data.json (2)
9-42: Great work on the entity type dropdown control! 👍The dropdown control is well-structured and provides a clear way for users to select the entity type they want to work with. The dynamic enabling and disabling of options based on the selected command is a nice touch that improves the user experience.
The form configuration evaluation ensures that the options are always up-to-date and relevant to the current state of the form.
Overall, this is a solid implementation of the entity type selection control.
67-92: The sheet name dropdown control is well-implemented! 👌The dropdown control provides a straightforward way for users to select the sheet they want to work with within the selected spreadsheet. The conditional display based on the selected entity type, command, and spreadsheet URL ensures that the control is only shown when necessary, keeping the form focused and relevant.
The dynamic value fetching is a valuable feature that populates the available options based on the sheets in the selected spreadsheet. This saves users from having to manually enter the sheet name and reduces the chances of errors.
The code for the sheet name dropdown control is clean, readable, and follows the established structure and conventions.
Great job on this control!
app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/editor/fetch_many.json (5)
2-10: Great work on upgrading the control type! 👍I see that you've updated the
controlTypefromSECTIONtoSECTION_V2. This change indicates an enhancement to the control's functionality or structure, which is a step in the right direction.I also noticed that the
identifierproperty remains unchanged, ensuring that the control can still be uniquely identified within the configuration.Keep up the good work! 🌟
11-45: Excellent restructuring of the children array! 🎉I noticed that you've reorganized the
childrenarray to include multiple sections, each with its own unique identifier (e.g.,FETCH_MANY-Z1,FETCH_MANY-Z2). This modular approach is fantastic as it improves the maintainability and readability of the configuration. 📚Moreover, the introduction of new control types like
DOUBLE_COLUMN_ZONEandSINGLE_COLUMN_ZONEis a great addition. These control types will enhance the layout and organization of the UI components, making it easier for users to navigate and interact with the plugin. 🎨Your efforts in restructuring the configuration are commendable and will definitely contribute to a better user experience. Well done! 👏
48-85: Fantastic enhancements to the Filter Format section! 🎉I see that you've made the
Filter Formatsection part of a more complex structure, which now includes additional options for filtering data. This change provides users with more flexibility and control over how they filter the data, making the plugin more versatile. 💪The redefinition of the
Cell rangeoption with a new property name (rows_get_cellRange) and tooltip text is a great improvement. It enhances clarity and makes it easier for users to understand the purpose of this option. 💡I also noticed that you've retained the conditionals for showing these elements. This is excellent as it ensures that the logic governing the visibility of the filtering options remains consistent with the previous implementation. 🎯
Overall, these changes to the
Filter Formatsection are a significant step forward in terms of functionality and usability. Great job! 🙌
90-187: Excellent addition of dedicated Rows Sections for filtering and sorting! 👏I noticed that you've introduced new
SINGLE_COLUMN_ZONEsections specifically for filtering and sorting rows. This is a fantastic improvement as it enhances the organization and clarity of these options within the configuration. 🏗️Moving the
Filter ByandSort Byoptions into these dedicated sections is a logical choice. It groups related configurations together, making it easier for users to understand and navigate the various options available for filtering and sorting data. 🗂️I also appreciate the use of conditionals to control the visibility of these sections based on the selected
queryFormat. This ensures that the filtering and sorting options are displayed only when relevant, providing a cleaner and more focused user interface. 🎚️These changes to the
Rows Sectionfor filtering and sorting are a significant improvement in terms of structure and usability. Well done! 🌟
188-217: Great work on refining the pagination configuration! 👍I see that you've moved the pagination configuration into a new
SINGLE_COLUMN_ZONEsection. This change improves the organization and separation of concerns within the configuration, making it easier to locate and manage the pagination settings. 📊The updates to the
placeholderTextandtooltipTextproperties are particularly helpful. They now provide clear guidance on how to bind the pagination values (limitandoffset) to widget properties. This improvement enhances usability by assisting users in correctly configuring the pagination functionality. 🔍I also noticed that you've retained the
initialValueforlimitandoffset. Maintaining consistency with the previous implementation is important to ensure a smooth transition for existing users. 🤝Overall, these changes to the pagination configuration are a step in the right direction. The dedicated section and improved guidance will make it easier for users to understand and configure pagination in their applications. Well done! 👏
|
Deploy-Preview-URL: https://ce-36117.dp.appsmith.com |
Failed server tests
|
ankitakinger
added
ok-to-test
…o use sections and zones format (appsmithorg#36117) ## Description Action redesign: Updating the config for Google sheets plugin to use sections and zones format Fixes [appsmithorg#35483](appsmithorg#35483) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10818868016> > Commit: 578b1ca > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10818868016&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Sep 2024 21:13:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced styling flexibility for dynamic input text controls with a new CSS class. - Updated Google Sheets plugin configuration to support improved layout and organization with new control types, including `SECTION_V2`, `DOUBLE_COLUMN_ZONE`, and `SINGLE_COLUMN_ZONE`. - Introduced a new `ENTITY_SELECTOR` component for streamlined entity selection in Google Sheets integration. - **Bug Fixes** - Resolved issues with minimum height and width constraints for dynamic input text controls, improving responsiveness. - **Style** - Improved layout responsiveness for various controls by removing hardcoded widths and enhancing CSS rules. - **Chores** - Made formatting adjustments to the HTML and JavaScript code for improved readability without impacting functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
Action redesign: Updating the config for Google sheets plugin to use sections and zones format
Fixes #35483
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10818868016
Commit: 578b1ca
Cypress dashboard.
Tags:
@tag.AllSpec:
Wed, 11 Sep 2024 21:13:39 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
SECTION_V2,DOUBLE_COLUMN_ZONE, andSINGLE_COLUMN_ZONE.ENTITY_SELECTORcomponent for streamlined entity selection in Google Sheets integration.Bug Fixes
Style
Chores