Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix failing table filter spec by rearranging steps. #36303

Merged
merged 3 commits into from
Sep 13, 2024
Merged

test: fix failing table filter spec by rearranging steps. #36303

merged 3 commits into from
Sep 13, 2024

Conversation

rahulbarwal
Copy link
Contributor

@rahulbarwal rahulbarwal commented Sep 13, 2024 •
edited by github-actions bot
Loading

Description

In the spec, feature flag intercept is interfering with navigating back to editor flow.
Since we need FF in the editor, this PR rearranges these steps.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10845920958
Commit: c7de064
Cypress dashboard.
Tags: @tag.Table
Spec:

Fri, 13 Sep 2024 09:23:14 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes

    • Improved test flow for the Table V2 component by repositioning navigation actions, enhancing clarity and context.

  • Chores

    • Updated the configuration for limited tests to focus on the Table V2 widget's filtering functionality instead of template-related tests.

@rahulbarwal rahulbarwal self-assigned this Sep 13, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024 •
edited
Loading

Walkthrough

The changes involve modifications to the Cypress testing framework for a table component. The TableV2Filter1_1_Spec.ts file has been updated to reposition the deployMode.NavigateBacktoEditor() function call to the beginning of the test case. Additionally, the limited-tests.txt file has been altered to change the specified test file from Fork_Template_spec.js to TableV2Filter1_1_Spec.ts, indicating a focus shift towards the filtering functionality of the Table V2 widget.

Changes

File Path Change Summary
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts Repositioned deployMode.NavigateBacktoEditor() to the start of the test case for clarity.
app/client/cypress/limited-tests.txt Updated test file reference from Fork_Template_spec.js to TableV2Filter1_1_Spec.ts.

Possibly related PRs

Suggested labels

Bug, ok-to-test, Task, Widgets Product, Table Widget

Poem

In the realm of tests so bright,
A table's flow now feels just right.
With changes made, we navigate,
To filter data, we celebrate!
Cypress guides our way anew,
Testing widgets, tried and true! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahulbarwal rahulbarwal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Sep 13, 2024
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Sep 13, 2024
@rahulbarwal
Copy link
Contributor Author

/ci-test-limit

@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Sep 13, 2024
@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10844712304.
Cypress dashboard
PR: #36303.

@sagar-qa007
Copy link
Contributor

/ci-test-limit-count run_count=15

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10844719201.
Cypress dashboard
PR: #36303.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10844712304.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@abhvsn abhvsn merged commit 5996f74 into release Sep 13, 2024
43 checks passed
@abhvsn abhvsn deleted the fix/table-filter-spec-failure branch September 13, 2024 09:13
This was referenced Sep 16, 2024
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 23, 2024
Merged
Closed
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
@rahulbarwal @Shivam-z
test: fix failing table filter spec by rearranging steps. (appsmithor…
218f22b 
…g#36303)

## Description
In the spec, feature flag intercept is interfering with navigating back
to editor flow.
Since we need FF in the editor, this PR rearranges these steps.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Table"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/10845920958>
> Commit: c7de064
> Workflow: `PR Automation test suite`
> Tags: `@tag.Table`
> Spec: ``
> <hr>Fri, 13 Sep 2024 08:40:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved test flow for the Table V2 component by repositioning
navigation actions, enhancing clarity and context.
  
- **Chores**
- Updated the configuration for limited tests to focus on the Table V2
widget's filtering functionality instead of template-related tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This was referenced Sep 27, 2024
Closed
Closed
Merged
Closed
Closed
This was referenced Oct 7, 2024
Merged
Closed
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 14, 2024
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagar-qa007 sagar-qa007 sagar-qa007 approved these changes

@ApekshaBhosale ApekshaBhosale Awaiting requested review from ApekshaBhosale ApekshaBhosale is a code owner

Assignees

@rahulbarwal rahulbarwal

Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test Widgets & Accelerators Pod Issues related to widgets & Accelerators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulbarwal @sagar-qa007 @abhvsn