chore: fix select1 spec

[jsartisan]

Summary by CodeRabbit

• Bug Fixes

  • Enhanced test functionality by adding a check for page save errors in the "Select1" test, improving error handling before executing further actions.

• Chores

  • Updated testing priorities by commenting out the "Fork Template" test and activating the "Select1" test in the limited tests configuration.

Warning

Tests have not run on the HEAD d248530 yet

---

Tue, 10 Sep 2024 11:37:57 UTC

[coderabbitai]

Walkthrough

The pull request introduces a modification to the Cypress test suite, specifically enhancing the Select1_spec.ts test by adding a page save error check at the beginning of a test case. Additionally, it updates the limited-tests.txt file to change the focus of limited tests from the "Fork Template" to the "Select1" test. These changes aim to improve test reliability and adjust testing priorities.

Changes

File Path	Change Summary
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts	Added a call to _.agHelper.CheckForPageSaveError(); at the start of a test case.
app/client/cypress/limited-tests.txt	Commented out the "Fork Template" test file and added the "Select1" test file.

Possibly related issues

• [Task]: Fix flakiness of app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts #35563: The changes in this PR address the flakiness issue of the Select1_spec.ts test by introducing a check for page save errors, which may help stabilize the test execution.

Poem

In the realm of code, a change took flight,
A test now checks for errors, making things right.
From "Fork Template" to "Select1" we steer,
Improving our tests, with each passing year.
With each line added, our confidence grows,
In the world of Cypress, our progress shows! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jsartisan]

/ci-test-limit-count run_count=15

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10790553598.
Cypress dashboard
PR: #36228.

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10790553598.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 150 Total Passed: 150 Total Failed: 0 Total Skipped: 0 *****************************