Do not merge : testing failure

[sagar-qa007]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10954967512
Commit: bba73ef
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Fri, 20 Sep 2024 08:18:54 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Updated testing focus to include the MapChart component, enhancing coverage for this functionality.

• Bug Fixes

  • Adjusted testing strategy to better align with current requirements.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the limited-tests.txt file, specifically changing the path of a test specification from Fork_Template_spec.js to MapChart_Spec.ts. This change reflects a strategic shift in testing focus from templates to the MapChart widget, indicating an adjustment in the testing approach without altering any public entity declarations.

Changes

Files	Change Summary
app/client/cypress/limited-tests.txt	Changed test specification path from cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js to cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts.

Possibly related PRs

• fix: Video2 spec flaky fix #36166: Modifies limited-tests.txt to change the path from Fork_Template_spec.js to Video2_Spec.ts, indicating a similar focus shift.
• fix: Fixed flaky fork template test case #36200: Updates limited-tests.txt by changing the test specification from Fork_Template_spec.js to Fork_Template_To_App_spec.ts, reflecting an adjustment in test focus.
• fix: flaky mongo spec test #36220: Modifies limited-tests.txt to replace Fork_Template_spec.js with Mongo_Spec.ts, indicating a shift in testing priorities.
• chore: fix select1 spec #36228: Updates limited-tests.txt by commenting out Fork_Template_spec.js and adding Select1_spec.ts, showing a pattern of changing test specifications.
• fix: Fixed Bug29566 spec with list widget #36260: Changes limited-tests.txt to replace Fork_Template_spec.js with Bug29566_Spec.ts, indicating a focus shift similar to the main PR.

🎉 In the realm of code, changes unfold,
From templates to widgets, new stories told.
The MapChart now shines, with tests in its sight,
A journey of focus, from day into night.
With each little tweak, our coverage will grow,
In the world of testing, we’re ready to go! 🌟

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 31a6223 and bba73ef.

Files selected for processing (1)

• app/client/cypress/limited-tests.txt (1 hunks)

Additional context used

Path-based instructions (1)

app/client/cypress/limited-tests.txt (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

Additional comments not posted (1)

app/client/cypress/limited-tests.txt (1)

2-2: Good work! The change looks appropriate.

The modification to run the MapChart widget test file instead of the template test file aligns well with the PR objective of addressing a testing failure. It's a positive step to focus the testing efforts on specific widgets rather than generic templates.

I appreciate that you've kept the commented section for running all specs intact. This ensures that the overall test execution structure remains flexible.

Keep up the great work! Let me know if you need any further assistance.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sagar-qa007]

/ci-test-limit-count run_count=5

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10878489648.
Cypress dashboard
PR: #36327.

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10878489648.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 35 Total Passed: 25 Total Failed: 10 Total Skipped: 0 *****************************