Merge pull request #746 from appsmithorg/input-sizes-generalising

fix: Updated sm size for DatePicker, Input, Number Input, and Search Input
appsmithorg · Jul 5, 2024 · ed99f0b · ed99f0b
2 parents a692320 + 4b94af2
commit ed99f0b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/.changeset/smart-socks-learn.md b/.changeset/smart-socks-learn.md
@@ -0,0 +1,5 @@
+---
+"@appsmithorg/design-system": patch
+---
+
+fix: Updated sm size for DatePicker, Input, Number Input, and Search Input
diff --git a/packages/design-system/src/Input/Input.styles.tsx b/packages/design-system/src/Input/Input.styles.tsx
@@ -15,7 +15,7 @@ const Variables = css`
   --input-padding-x: var(--ads-v2-spaces-2); // padding left and right
   --input-padding-y: var(--ads-v2-spaces-2); // padding top and bottom
   --input-font-size: var(--ads-v2-font-size-2);
-  --input-height: 22px;
+  --input-height: 24px;
 `;
 
 const getSizes = (size: InputSizes, component: "input" | "textarea") => {
@@ -24,7 +24,7 @@ const getSizes = (size: InputSizes, component: "input" | "textarea") => {
       --input-padding-x: var(--ads-v2-spaces-2);
       --input-padding-y: var(--ads-v2-spaces-2);
       --input-font-size: var(--ads-v2-font-size-2);
-      --input-height: ${component === "input" ? "22px" : "60px"};
+      --input-height: ${component === "input" ? "24px" : "60px"};
     `,
     md: css`
       --input-padding-x: var(--ads-v2-spaces-3);

diff --git a/packages/design-system/src/SearchInput/SearchInput.styles.tsx b/packages/design-system/src/SearchInput/SearchInput.styles.tsx
@@ -7,13 +7,11 @@ const Sizes = {
     --input-font-size: 14px;
     --input-padding-x: var(--ads-v2-spaces-3); // padding left and right
     --input-padding-y: var(--ads-v2-spaces-2); // padding top and bottom
-    --input-height: 28px;
   `,
   md: css`
     --input-padding-x: var(--ads-v2-spaces-3);
     --input-padding-y: var(--ads-v2-spaces-3);
     --input-font-size: var(--ads-v2-font-size-4);
-    --input-height: 36px;
   `,
 };