Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

fix: Updated sm size for DatePicker, Input, Number Input, and Search Input #746

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

albinAppsmith
Copy link
Contributor

Description

Previously, Form input elements had different sm sizes.
Button -> 24px
Datepicker -> 22px
Input -> 22px
Search Input -> 28px
Number Input -> 22px
Select -> 24px

This PR updates all these to 24px.

Fixes appsmithorg/appsmith#34599

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 5:39am

Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: 4b94af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@albinAppsmith
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Publish Result: @appsmithorg/design-system@0.0.0-alpha-20240701054242

@albinAppsmith albinAppsmith merged commit ed99f0b into release Jul 5, 2024
9 checks passed
@albinAppsmith albinAppsmith deleted the input-sizes-generalising branch July 5, 2024 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update design system form control height to 24px for "sm" size
2 participants