Monitoring of OLM, catalog, and marketplace operators by SYN stack #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastjan
changed the title
simu
approved these changes
Jul 6, 2022
| ], | ||
| }; | ||
|
|
||
| local marketplaceOperatorMonitor = prom.ServiceMonitor('openshift-marketplace-operator') { |
There was a problem hiding this comment.
According to the internal ticket the marketplace operator only provides Go runtime metrics, do we really need a ServiceMonitor for it which drops all metrics?
There was a problem hiding this comment.
I did do it to be analogue to the others. Maybe they will add metrics at some point. At least we get the up from it...
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on the beta cluster with both valid instances at once.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.