Remove support for component-prometheus based monitoring #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labeled as Technically speaking, this is a breaking change. We could mark the PR as |
We've ended up never using component-prometheus on OpenShift 4, and have changed our strategy to build OpenShift 4 monitoring on the cluster-monitoring and user-workload-monitoring stacks provided by OpenShift 4. Therefore the logic to enable a component-prometheus monitoring stack to scrape metrics from namespaces/workloads managed through this component is no longer necessary. This commit completely removes support for component-prometheus in this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've ended up never using component-prometheus on OpenShift 4, and have changed our strategy to build OpenShift 4 monitoring on the cluster-monitoring and user-workload-monitoring stacks provided by OpenShift 4. Therefore the logic to enable a component-prometheus monitoring stack to scrape metrics from namespaces/workloads managed through this component is no longer necessary.
This PR completely removes support for component-prometheus in this component.
Reverts #12
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.