Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin default version to v1.0.0 #13

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Pin default version to v1.0.0 #13

merged 1 commit into from
Jul 20, 2021

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jul 20, 2021

Both exoscale and cloudscale module versions have a v1
This is to prepare the component for another v1 release that has a default version parameter to something that is considered current "master" branch before introducing breaking changes.

After such release, the version can be bumped to v2.0.0 for the cloudscale provider.

Should be merged before #12

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@ccremer ccremer added the change label Jul 20, 2021
@ccremer ccremer requested a review from simu July 20, 2021 09:12
@ccremer
Copy link
Contributor Author

ccremer commented Jul 20, 2021

@simu
The cloudscale and exoscale terraform repos don't have a documentation module where I could document the upgrade process.
Is this repository the right place to do it? It already has how-to pages for those providers

Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably fine to document the TF module upgrade process in this repo, since the modules themselves are currently not really documented properly.

class/defaults.yml Outdated Show resolved Hide resolved
@ccremer ccremer requested a review from simu July 20, 2021 09:23
@ccremer
Copy link
Contributor Author

ccremer commented Jul 20, 2021

I propose to add the upgrade documentation as part of #12

Different providers can diverge with their versionings.
This change makes it possible to support a default version based on the selected provider.
@ccremer ccremer merged commit 2be6ba1 into master Jul 20, 2021
@ccremer ccremer deleted the version-pin branch July 20, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants