Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for puppet-managed LBs on cloudscale #12

Merged
merged 6 commits into from
Jul 20, 2021
Merged

Add support for puppet-managed LBs on cloudscale #12

merged 6 commits into from
Jul 20, 2021

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jul 19, 2021 •
edited
Loading

  • Updates the component and docs to use with puppet-managed load balancers.
  • Aligns Exoscale and Cloudscale how-to pages, uses a partial

Related:

Labelled Breaking since now an terraform_variables.ssh_keys is necessary for cloudscale provider.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@ccremer ccremer force-pushed the cloudscale-lb branch 3 times, most recently from 90ae3d3 to c5e3d37 Compare July 20, 2021 07:38
@ccremer ccremer marked this pull request as ready for review July 20, 2021 07:39
@ccremer ccremer requested a review from simu July 20, 2021 07:39
@ccremer
Copy link
Contributor Author

ccremer commented Jul 20, 2021 •
edited
Loading

Note: The GH action fails as long as version is set to master, because appuio/terraform-openshift4-cloudscale#19 is not merged yet. (test run locally succeeds)

simu
simu approved these changes Jul 20, 2021
View reviewed changes
component/main.jsonnet Outdated Show resolved Hide resolved
@ccremer ccremer mentioned this pull request Jul 20, 2021
Merged
3 tasks
@ccremer ccremer requested a review from simu July 20, 2021 10:21
simu
simu approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC cloudscale.ch prefers if their name is not capitalized.

docs/modules/ROOT/pages/how-tos/upgrade-cloudscale-v1-v2.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/upgrade-cloudscale-v1-v2.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/upgrade-cloudscale-v1-v2.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/upgrade-cloudscale-v1-v2.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/upgrade-cloudscale-v1-v2.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/use-cloudscale.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/use-cloudscale.adoc Outdated Show resolved Hide resolved
@simu simu requested a review from corvus-ch July 20, 2021 10:43
@ccremer ccremer merged commit 2f049e4 into master Jul 20, 2021
@ccremer ccremer deleted the cloudscale-lb branch July 20, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corvus-ch corvus-ch corvus-ch approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccremer @simu @corvus-ch