Support Puppet-managed LoadBalancers #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccremer
force-pushed
the
hiera
branch
2 times, most recently
from
007ac13 to
19acdc2
Compare
|
Cleaned up the git history a bit |
simu
approved these changes
Jul 19, 2021
| @@ -0,0 +1,16 @@ | |||
| #!/bin/sh | |||
|
|
|||
| set -eo pipefail | |||
There was a problem hiding this comment.
Please make sure that this is backported to https://github.com/appuio/terraform-openshift4-exoscale
corvus-ch
approved these changes
Jul 19, 2021
This was referenced Jul 19, 2021
Merged
To be aligned with terraform-exoscale
There's a risk of getting into a terraform timeout after 5 minutes, in which case the state becomes corrupted even if the VM later succeeds with provisioning in the background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change. See the upgrade documentation at https://github.com/appuio/component-openshift4-terraform