Accidental failures to login to SQL Server

[morozov]

From time to time (e.g. doctrine/dbal#1.0.47, more can be added if needed), the following error appears in the build log:

SQLSTATE [28000, 18456]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Login failed for user 'sa'.
SQLSTATE [42000, 4060]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Cannot open database "doctrine_tests" requested by the login. The login failed.

I don't have any hard evidence that the problem is on the AppVeyor side but I see it only on AppVeyor (e.g. doesn't happen on 30+ different Travis CI configurations including SQL Server on Linux).

[IlyaFinkelshteyn]

Given the fact that it is intermittent and that you start SQL right before tests, I would speculate that problem is that SQL is not completely started by the time test started (sometimes). Start-Service is asynchronous and returns before service actually started. Try to add waiting for service status to be running or simple use synchronous net start command. Or start it earlier (say at install stage. Let us know if this helps.

[photodude]

@IlyaFinkelshteyn nevermind... I Just noticed the option for services: matrix start for all versions is now available testing that now

[IlyaFinkelshteyn]

@photodude I did not mention this because you can get too much jobs you do not need. You can exclude them though.

[photodude]

@IlyaFinkelshteyn Just ran a test with the matrix service start and it hung on the first test at 4% in phpunit

https://ci.appveyor.com/project/photodude/dbal/build/1.0.305/job/brmknshwme5e1nlg

I put the services in the matrix so only one service should be starting with each of the builds in the matrix https://github.com/photodude/dbal/blob/patch-2/.appveyor.yml

[IlyaFinkelshteyn]

@photodude oh, sorry, services is not first class matrix dimension. Filed #2207 to make it work inside matrix. For now I believe try just net start (or Start-Service with custom waiting)...