Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start SQL Server using a synchronous command to avoid intermittent login failures #3071

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Start SQL Server using a synchronous command to avoid intermittent login failures #3071

merged 1 commit into from
Mar 27, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 27, 2018 •
edited
Loading

@morozov morozov mentioned this pull request Mar 27, 2018
Merged
@morozov morozov requested a review from Ocramius March 27, 2018 00:55
@photodude
Copy link
Contributor

we should use the services: option in the matrix for all versions since that's now a thing

@morozov
Copy link
Member Author

morozov commented Mar 27, 2018

@photodude could you point to the reference?

@photodude
Copy link
Contributor

reference is the documentation. I just noticed they changed it to specify a service start via the matrix. testing it now.
https://github.com/photodude/dbal/blob/patch-2/.appveyor.yml

unfortunately, it has hung on the first test at 4%
https://ci.appveyor.com/project/photodude/dbal/build/1.0.305/job/brmknshwme5e1nlg

@photodude
Copy link
Contributor

photodude commented Mar 27, 2018 •
edited
Loading

It just progressed to 5% with major errors... I'm thinking the service failed to start.
https://ci.appveyor.com/project/photodude/dbal/build/1.0.305/job/brmknshwme5e1nlg

Guess the documentation for using the matrix service start is a bad idea
Looks like it turned out to be an unsupported method for starting the services.

@photodude
Copy link
Contributor

As per the suggestions by Appveyor and the pending improvement of appveyor/ci#2207

The change from Start-Service to net start commands is the best current solution.

@morozov
Copy link
Member Author

morozov commented Mar 27, 2018

@Ocramius ⚡ ⚡ ⚡

@Majkl578 Majkl578 merged commit 1853a6d into doctrine:master Mar 27, 2018
@Majkl578
Copy link
Contributor

💣

@Majkl578 Majkl578 self-assigned this Mar 27, 2018
@Majkl578 Majkl578 added the CI label Mar 27, 2018
@Majkl578 Majkl578 added this to the 2.7.0 milestone Mar 27, 2018
@Ocramius
Copy link
Member

🐝

@morozov morozov deleted the mssql-net-start branch March 27, 2018 20:11
@Majkl578 Majkl578 mentioned this pull request Mar 28, 2018
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Majkl578 Majkl578 Majkl578 approved these changes

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@Majkl578 Majkl578

Labels
CI
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@morozov @photodude @Majkl578 @Ocramius