Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute environment variable in 'service' name #2207

Open
IlyaFinkelshteyn opened this issue Mar 27, 2018 · 3 comments
Open

Substitute environment variable in 'service' name #2207

IlyaFinkelshteyn opened this issue Mar 27, 2018 · 3 comments

Comments

@IlyaFinkelshteyn
Copy link
Contributor

No description provided.

@IlyaFinkelshteyn
Copy link
Contributor Author

This will enable scenario like this:

environment:
 matrix:
   - sqlver: mssql2014
   - sqlver: mssql2016

services:
  - $(sqlver)

@photodude
Copy link

photodude commented Mar 27, 2018

This form would also be nice to have for these kinds of multiple SQL version testing scenarios

environment:
  matrix:
  - db: mssql
    driver: sqlsrv
    db_version: sql2008r2sp2
    php: 7.2
    services: mssql2008r2sp2
  - db: mssql
    driver: sqlsrv
    db_version: sql2012sp1
    php: 7.2
    services: mssql2012sp1

@photodude
Copy link

Thank you @IlyaFinkelshteyn for filing this. I believe this will be a good improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants