Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make database open attempts configurable also via config file #869

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

steinex
Copy link
Contributor

@steinex steinex commented Aug 21, 2019

Description of the Change

This makes the global command line flag -db-open-attempts a configuration option in aptly.conf (as databaseOpenAttempts).

We'd rather configure it there instead of adding the flag to every invocation of aptly in our CI/CD setup.

I couldn't test this change thoroughly, but I oriented on how it was done for other, similar flags/options.

Thanks!

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@steinex steinex force-pushed the databaseOpenAttempts branch 2 times, most recently from 6f9b268 to ec074c1 Compare August 21, 2019 12:10
@steinex steinex force-pushed the databaseOpenAttempts branch from ec074c1 to e5d9a11 Compare August 21, 2019 12:54
Copy link
Contributor

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! 👍

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #869 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   63.84%   63.81%   -0.03%     
==========================================
  Files          54       54              
  Lines        6651     6654       +3     
==========================================
  Hits         4246     4246              
- Misses       1881     1884       +3     
  Partials      524      524
Impacted Files Coverage Δ
utils/config.go 64.7% <ø> (ø) ⬆️
context/context.go 11.14% <0%> (-0.14%) ⬇️
deb/remote.go 60.92% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d7c38...e5d9a11. Read the comment docs.

@smira smira merged commit 98e75f6 into aptly-dev:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants