[move-compiler] Fix panic in coverage for inlined code, add controls to display tags and/or color in coverage source listings, don't lean on compiler v1 #14449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brmataptos
changed the title
brmataptos
force-pushed
the
brm-issue-14360
branch
from
b988e21 to
ee8bc20
Compare
vineethk
reviewed
Aug 29, 2024
| if cov.uncovered_locations.is_empty() { | ||
| return vec![]; | ||
| } | ||
|
|
||
| let mut covs: Vec<_> = cov | ||
| .uncovered_locations | ||
| .iter() | ||
| .filter(|loc| loc.file_hash() == file_hash) |
There was a problem hiding this comment.
This change introduces a new crash: #14454
It can be fixed by adding a check that if covs.is_empty() { return vec![]; } right after creating covs here.
There was a problem hiding this comment.
I had filed the crash while reviewing, but I did not realize until after filing the bug that the root cause was this change.
There was a problem hiding this comment.
If you have tested the scenario mentioned in the issue and it is fixed, then you can mention in the PR description that it also fixes that issue so that it gets closed.
vineethk
reviewed
Aug 29, 2024
| install_dir: move_options.output_dir.clone(), | ||
| skip_fetch_latest_git_deps: move_options.skip_fetch_latest_git_deps, | ||
| compiler_config: CompilerConfig { | ||
| known_attributes: extended_checks::get_all_attribute_names().clone(), | ||
| skip_attribute_checks: false, |
There was a problem hiding this comment.
Should skip_attribute_checks also not be copied from move_options?
| source_coverage | ||
| .compute_source_coverage(source_path) | ||
| .output_source_coverage(&mut std::io::stdout()) | ||
| let t1 = source_coverage.compute_source_coverage(source_path); |
There was a problem hiding this comment.
Please undo or use better var names.
| source_cov | ||
| .compute_source_coverage(source_path) | ||
| .output_source_coverage(&mut coverage_writer) | ||
| let t1 = source_cov.compute_source_coverage(source_path); |
There was a problem hiding this comment.
Please undo or use better var names.
| } | ||
|
|
||
| #[derive(ValueEnum, Clone, Debug, Serialize)] | ||
| pub enum TextIndicator { |
There was a problem hiding this comment.
Would be good to have a brief note on what these mean.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14449 +/- ##
=========================================
- Coverage 59.7% 59.6% -0.1%
=========================================
Files 844 844
Lines 205737 205834 +97
=========================================
+ Hits 122831 122845 +14
- Misses 82906 82989 +83 ☔ View full report in Codecov by Sentry. |
vineethk
approved these changes
Aug 29, 2024
brmataptos
force-pushed
the
brm-issue-14360
branch
from
f92dedc to
4dad30b
Compare
…Fix panic by dropping inlined code from source coverage listings.
brmataptos
force-pushed
the
brm-issue-14360
branch
from
4dad30b to
a82f083
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add controls for how
aptos move coverage sourcedisplays covered source code:--color {none, default, always}, by default keep current behavior--tag {none, explicit, on}, when turnedexplicitoron, show+and-for covered/uncovered linesFix a panic for
aptos move coverage source --module featuresonaptos-move/framework/move-stdlib, caused by inlined lines beingmisattributed to the calling module.
Also fix
aptos move test --coverageto not rely on V1 compiler.Issue #14448 created to track remaining coverage issues.
Fixes #14377
Fixes #14360
Fixes #14379
Fixes #14454
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Manual testing, piped to files and less, etc.
Key Areas to Review
Uncolored output of
aptos move coverage source --module featuresnow looks like:With color, lines are green with uncovered parts in red.
Checklist