Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF] More fixes for GCP DNS #8253

Merged
merged 2 commits into from
Jun 5, 2023
Merged

[TF] More fixes for GCP DNS #8253

merged 2 commits into from
Jun 5, 2023

Conversation

sionescu
Copy link
Contributor

@sionescu sionescu commented May 17, 2023 •
edited
Loading

Description

  • add variable to control the record TTL and lower the default from 1h to 5min, as the rest of the records on GCP
  • add variable create_dns_records to the testnet module as well, to be useable from the devnet module

Test Plan

Tested on the new GCP Devnet.

@sionescu sionescu requested a review from a team as a code owner May 17, 2023 20:07
@sionescu sionescu enabled auto-merge (squash) May 17, 2023 20:07
@sionescu sionescu force-pushed the stelian/gcp-testnet-dns branch from 00e0197 to 0d98f20 Compare May 17, 2023 20:09
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
rustielin
rustielin approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@rustielin rustielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you also still need this #8160 in conjunction with this PR?

@sionescu
Copy link
Contributor Author

@rustielin Do we need the create_records variable ?

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@rustielin
Copy link
Contributor

@sionescu I think it makes sense in a world where we don't care about DNS but still want a testnet or single node. It's mostly for test cases, and also brings it up to parity to the AWS setup

@sionescu sionescu force-pushed the stelian/gcp-testnet-dns branch from 0d98f20 to 95902fe Compare May 17, 2023 21:01
@sionescu
Copy link
Contributor Author

@rustielin Yes, in that case let's merge #8160.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sionescu sionescu force-pushed the stelian/gcp-testnet-dns branch from 95902fe to d335ebf Compare May 17, 2023 23:17
@github-actions

This comment has been minimized.

Sign in to view
@sionescu sionescu force-pushed the stelian/gcp-testnet-dns branch 2 times, most recently from a2e0e21 to 940c7f2 Compare May 31, 2023 21:13
@sionescu sionescu force-pushed the stelian/gcp-testnet-dns branch 10 times, most recently from eb8d430 to 6c2f76e Compare June 5, 2023 16:23
sionescu added 2 commits June 5, 2023 17:36
@sionescu
[TF] More fixes for GCP DNS
6e9e3c4 
* add variable to control the record TTL and lower the default from 1h
to 5min, as the rest of the records on GCP
* add variable *create_dns_records* to the testnet module as well, to
be useable from the devnet module
@sionescu
Enable Ingress routing on GKE
7829895 
* provision certificates
* add custom health checks the way GKE likes it
@sionescu sionescu force-pushed the stelian/gcp-testnet-dns branch from 6c2f76e to 7829895 Compare June 5, 2023 21:36
@rustielin rustielin self-requested a review June 5, 2023 22:53
@sionescu sionescu enabled auto-merge (squash) June 5, 2023 23:22
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 7829895135710330380ab860b9977f8706aaf3b8

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 7829895135710330380ab860b9977f8706aaf3b8 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10174 TPS, 3704 ms latency, 6100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 7829895135710330380ab860b9977f8706aaf3b8
compatibility::simple-validator-upgrade::single-validator-upgrade : 5799 TPS, 6896 ms latency, 9400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 7829895135710330380ab860b9977f8706aaf3b8
compatibility::simple-validator-upgrade::half-validator-upgrade : 6001 TPS, 6468 ms latency, 9400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 7829895135710330380ab860b9977f8706aaf3b8
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8292 TPS, 4597 ms latency, 7800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 7829895135710330380ab860b9977f8706aaf3b8 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ Forge suite land_blocking success on 7829895135710330380ab860b9977f8706aaf3b8

performance benchmark : 5658 TPS, 6975 ms latency, 27100 ms p99 latency,(!) expired 402 out of 2416380 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 7829895135710330380ab860b9977f8706aaf3b8

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 7829895135710330380ab860b9977f8706aaf3b8 (PR)
Upgrade the nodes to version: 7829895135710330380ab860b9977f8706aaf3b8
framework_upgrade::framework-upgrade::full-framework-upgrade : 5572 TPS, 7166 ms latency, 13200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 7829895135710330380ab860b9977f8706aaf3b8 passed
Test Ok

@sionescu sionescu merged commit 95ff72e into main Jun 5, 2023
@sionescu sionescu deleted the stelian/gcp-testnet-dns branch June 5, 2023 23:58
gedigi pushed a commit that referenced this pull request Jun 6, 2023
@sionescu @gedigi
[TF] More fixes for GCP DNS (#8253)
c35bed4
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
banool pushed a commit that referenced this pull request Jul 7, 2023
@sionescu @banool
[TF] More fixes for GCP DNS (#8253)
a963526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry-x sherry-x sherry-x approved these changes

@rustielin rustielin rustielin approved these changes

@geekflyer geekflyer Awaiting requested review from geekflyer

@perryjrandall perryjrandall Awaiting requested review from perryjrandall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sionescu @rustielin @sherry-x