Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting installation path to CLI install script #8446

Merged
merged 1 commit into from
May 31, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented May 31, 2023

Description

This support was already mostly there, we just had to use it. This will be helpful for CI.

Test Plan

$ python3 developer-docs-site/static/scripts/install_cli.py --bin-dir /tmp
Latest CLI release: 1.0.14
Currently installed CLI: None
Determined target to be: MacOSX-x86_64

Welcome to the Aptos CLI installer!

This will download and install the latest version of the Aptos CLI at this location:

/tmp

Installing Aptos CLI (1.0.14): Downloading...
Installing Aptos CLI (1.0.14): Done!

The Aptos CLI (1.0.14) is installed now. Great!

To get started you need the Aptos CLI's bin directory (/tmp) in your `PATH`
environment variable.

Add the following to your shell configuration file (e.g. .bashrc):

export PATH="/tmp:$PATH"

After this, restart your terminal.

Alternatively, you can call the Aptos CLI explicitly with `/tmp/aptos`.

You can test that everything is set up by executing:

aptos info

$ python3 developer-docs-site/static/scripts/install_cli.py --bin-dir /tmp
Latest CLI release: 1.0.14
Currently installed CLI: 1.0.14

The latest version (1.0.14) is already installed.
$ mkdir ehhh
$ python3 developer-docs-site/static/scripts/install_cli.py --bin-dir ~/ehhh
Latest CLI release: 1.0.14
Currently installed CLI: None
Determined target to be: MacOSX-x86_64

Welcome to the Aptos CLI installer!

This will download and install the latest version of the Aptos CLI at this location:

/Users/dport/ehhh

Installing Aptos CLI (1.0.14): Downloading...
Installing Aptos CLI (1.0.14): Done!

The Aptos CLI (1.0.14) is installed now. Great!

To get started you need the Aptos CLI's bin directory (/Users/dport/ehhh) in your `PATH`
environment variable.

Add the following to your shell configuration file (e.g. .bashrc):

export PATH="/Users/dport/ehhh:$PATH"

After this, restart your terminal.

Alternatively, you can call the Aptos CLI explicitly with `/Users/dport/ehhh/aptos`.

You can test that everything is set up by executing:

aptos info

$ python3 developer-docs-site/static/scripts/install_cli.py --bin-dir ~/ehhh
Latest CLI release: 1.0.14
Currently installed CLI: 1.0.14

The latest version (1.0.14) is already installed.

$ python3 developer-docs-site/static/scripts/install_cli.py
Latest CLI release: 1.0.14
Currently installed CLI: 1.0.14

The latest version (1.0.14) is already installed.

@banool banool marked this pull request as ready for review May 31, 2023 13:31
@banool banool enabled auto-merge (squash) May 31, 2023 14:31
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 18a58be4e02b66b2e3e5580fa903ece166f2750f

performance benchmark : 5348 TPS, 7377 ms latency, 28000 ms p99 latency,(!) expired 376 out of 2284220 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 18a58be4e02b66b2e3e5580fa903ece166f2750f

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 18a58be4e02b66b2e3e5580fa903ece166f2750f (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 9035 TPS, 4243 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 18a58be4e02b66b2e3e5580fa903ece166f2750f
compatibility::simple-validator-upgrade::single-validator-upgrade : 5678 TPS, 6800 ms latency, 9500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 18a58be4e02b66b2e3e5580fa903ece166f2750f
compatibility::simple-validator-upgrade::half-validator-upgrade : 5368 TPS, 7501 ms latency, 10000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 18a58be4e02b66b2e3e5580fa903ece166f2750f
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7853 TPS, 4977 ms latency, 8800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 18a58be4e02b66b2e3e5580fa903ece166f2750f passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 18a58be4e02b66b2e3e5580fa903ece166f2750f

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 18a58be4e02b66b2e3e5580fa903ece166f2750f (PR)
Upgrade the nodes to version: 18a58be4e02b66b2e3e5580fa903ece166f2750f
framework_upgrade::framework-upgrade::full-framework-upgrade : 6270 TPS, 6424 ms latency, 11000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 18a58be4e02b66b2e3e5580fa903ece166f2750f passed
Test Ok

@banool banool merged commit c522f80 into main May 31, 2023
@banool banool deleted the banool/cli-install-script-dir branch May 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants