Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get-latest-cli action #8447

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add get-latest-cli action #8447

merged 1 commit into from
Jun 1, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented May 31, 2023 •
edited
Loading

Description

This PR adds a GH action to install the CLI.

We could theoretically expand this to create a profile as well but I felt that made the action sort of complicated (just look at aptos init, it has a lot of flags we'd probably want to expose). We can chat about that though.

Depends on #8446.

Test Plan

@brianolson tested this in internal-ops, thanks Brian!!

@banool banool changed the base branch from main to banool/cli-install-script-dir May 31, 2023 13:37
@banool banool changed the title banool/get latest cli action Add get-latest-cli action May 31, 2023
@banool banool force-pushed the banool/get-latest-cli-action branch from b751efa to 53c21be Compare May 31, 2023 13:40
@banool banool marked this pull request as ready for review May 31, 2023 13:41
@banool banool requested a review from a team as a code owner May 31, 2023 13:41
Base automatically changed from banool/cli-install-script-dir to main May 31, 2023 15:36
rustielin
rustielin approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@rustielin rustielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Left a comment above, but otherwise looks good

.github/actions/get-latest-cli/action.yaml Outdated
name: "Get latest Aptos CLI"
description: |
Fetches the latest released Aptos CLI and optionally sets it up to operate against
a given network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the CLI set against a specific network?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, mb, let me remove that comment.

@banool banool force-pushed the banool/get-latest-cli-action branch 2 times, most recently from 61b5dc7 to 2cdb4ce Compare May 31, 2023 15:56
@banool banool force-pushed the banool/get-latest-cli-action branch from 2cdb4ce to 71dbcf1 Compare May 31, 2023 17:11
@banool banool enabled auto-merge (squash) May 31, 2023 17:12
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 71dbcf1facad3e5976f17823966015953d186cd1

performance benchmark : 5637 TPS, 7024 ms latency, 22900 ms p99 latency,(!) expired 120 out of 2407180 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 71dbcf1facad3e5976f17823966015953d186cd1

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 71dbcf1facad3e5976f17823966015953d186cd1 (PR)
Upgrade the nodes to version: 71dbcf1facad3e5976f17823966015953d186cd1
framework_upgrade::framework-upgrade::full-framework-upgrade : 6160 TPS, 6638 ms latency, 20700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 71dbcf1facad3e5976f17823966015953d186cd1 passed
Test Ok

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 71dbcf1facad3e5976f17823966015953d186cd1

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 71dbcf1facad3e5976f17823966015953d186cd1 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 9833 TPS, 3811 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 71dbcf1facad3e5976f17823966015953d186cd1
compatibility::simple-validator-upgrade::single-validator-upgrade : 5802 TPS, 6812 ms latency, 9600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 71dbcf1facad3e5976f17823966015953d186cd1
compatibility::simple-validator-upgrade::half-validator-upgrade : 5869 TPS, 6762 ms latency, 8800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 71dbcf1facad3e5976f17823966015953d186cd1
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8009 TPS, 4733 ms latency, 8200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 71dbcf1facad3e5976f17823966015953d186cd1 passed
Test Ok

@banool banool merged commit 931f810 into main Jun 1, 2023
@banool banool deleted the banool/get-latest-cli-action branch June 1, 2023 04:58
gedigi pushed a commit that referenced this pull request Jun 6, 2023
@banool @gedigi
Add get-latest-cli action (#8447)
edf0146
@qdrs qdrs mentioned this pull request Jun 20, 2023
Closed
banool added a commit that referenced this pull request Jul 7, 2023
@banool
Add get-latest-cli action (#8447)
aec3d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustielin rustielin rustielin approved these changes

@brianolson brianolson brianolson approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@gregnazario gregnazario Awaiting requested review from gregnazario

@saharct saharct Awaiting requested review from saharct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banool @brianolson @rustielin