-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the order of signer and non-signer tx arg validation to maintain backward compatibility #8649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…backward compatibility
movekevin
requested review from
runtian-zhou,
vgao1996,
gerben-stavenga and
sherry-x
June 13, 2023 23:13
zekun000
approved these changes
Jun 14, 2023
wrwg
approved these changes
Jun 14, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
movekevin
added a commit
that referenced
this pull request
Jun 14, 2023
…backward compatibility (#8649)
movekevin
added a commit
that referenced
this pull request
Jun 14, 2023
…backward compatibility (#8649)
vusirikala
pushed a commit
that referenced
this pull request
Jun 21, 2023
…backward compatibility (#8649)
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
…backward compatibility (#8649)
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
…backward compatibility (aptos-labs#8649)
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
…backward compatibility (aptos-labs#8649)
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
…backward compatibility (#8649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit broke compatibility in the past because transactions with mismatching numbers of senders vs what the number of signers the invoked function expects would result in mismatching senders error before the change and failed to deserialize error (from constructing non-signer args) after.
Test Plan
Replay tests