Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of signer and non-signer tx arg validation to maintain backward compatibility #8659

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

movekevin
Copy link
Contributor

Cherrypicked c9a3d5c

@movekevin movekevin changed the base branch from main to aptos-release-v1.5 June 14, 2023 12:47
@movekevin movekevin enabled auto-merge (squash) June 14, 2023 12:47
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@movekevin movekevin disabled auto-merge June 14, 2023 13:09
@movekevin movekevin merged commit dbaef40 into aptos-release-v1.5 Jun 14, 2023
@movekevin movekevin deleted the cherrypick1.5 branch June 14, 2023 13:09
@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c26a7510a0917892913cc63a9098897da3232ff9

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c26a7510a0917892913cc63a9098897da3232ff9 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10052 TPS, 3765 ms latency, 6300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: c26a7510a0917892913cc63a9098897da3232ff9
compatibility::simple-validator-upgrade::single-validator-upgrade : 5899 TPS, 6687 ms latency, 8700 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: c26a7510a0917892913cc63a9098897da3232ff9
compatibility::simple-validator-upgrade::half-validator-upgrade : 5870 TPS, 6673 ms latency, 8800 ms p99 latency,no expired txns
4. upgrading second batch to new version: c26a7510a0917892913cc63a9098897da3232ff9
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7480 TPS, 5065 ms latency, 8100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c26a7510a0917892913cc63a9098897da3232ff9 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on c26a7510a0917892913cc63a9098897da3232ff9

performance benchmark : 5477 TPS, 7202 ms latency, 27500 ms p99 latency,(!) expired 282 out of 2339260 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c26a7510a0917892913cc63a9098897da3232ff9

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c26a7510a0917892913cc63a9098897da3232ff9 (PR)
Upgrade the nodes to version: c26a7510a0917892913cc63a9098897da3232ff9
framework_upgrade::framework-upgrade::full-framework-upgrade : 7323 TPS, 5704 ms latency, 9100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c26a7510a0917892913cc63a9098897da3232ff9 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants