feat: add group api for UI module #344 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettcc
changed the title
dongzl
approved these changes
Aug 22, 2022
georgehao
reviewed
Aug 22, 2022
| err := service.UpsertGroup(context.Background(), tenantName, "", "", group) | ||
| if err != nil { | ||
| _ = c.Error(err) | ||
| return |
There was a problem hiding this comment.
package main
import (
"errors"
"github.com/gin-gonic/gin"
)
func main() {
g := gin.Default()
g.GET("/11", func(context *gin.Context) {
context.Error(errors.New("111"))
})
g.Run()
}结果：
dongzl
approved these changes
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
| func CreateGroup(c *gin.Context) { | ||
| service := admin.GetService(c) | ||
| tenantName := c.Param("tenant") | ||
| var group *boot.GroupBody |
There was a problem hiding this comment.
I think it should be boot.GroupBody.
jjeffcaii
reviewed
Aug 23, 2022
| service := admin.GetService(c) | ||
| tenant := c.Param("tenant") | ||
| group := c.Param("group") | ||
| var groupBody *boot.GroupBody |
jjeffcaii
reviewed
Aug 23, 2022
pkg/admin/router/db_groups.go
Outdated
Comment on lines
30
to
32
| import ( | ||
| "github.com/gin-gonic/gin" | ||
| ) |
There was a problem hiding this comment.
The 3rd imports should before arana imports, pls reformat
jjeffcaii
approved these changes
Aug 23, 2022
AlexStocks
approved these changes
Aug 31, 2022
chuntaojun
pushed a commit
to chuntaojun/arana
that referenced
this pull request
Sep 4, 2022
* add: missing interfaces in proto files and discovery files * feat: group api in file db_groups.go (arana-db#344) * style: add license header and add tool: imports-formatter * style: fix import
jjeffcaii
added a commit
that referenced
this pull request
Sep 4, 2022
* feat: add group api for UI module #344 (#373) * add: missing interfaces in proto files and discovery files * feat: group api in file db_groups.go (#344) * style: add license header and add tool: imports-formatter * style: fix import * feat: support notify event * refactor:config center * none * feat: none * refactor:split config and add change watch * style: fix code style * fix: fix func call error * fix: ci error * style:fix code style * fix: fix code style * refactor: rebase upstream * fix:add cluster info to list groups Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com> Co-authored-by: Jeffsky <jjeffcaii@outlook.com>
AlexStocks
pushed a commit
that referenced
this pull request
Sep 10, 2022
* feat: add admin api server skeleton (#330) * feat(config): add config updater api (#336) * add http server api for cluster. (#352) * add http server api for tenant (#366) * add http server api for tenant * fix import format * fix go format Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com> * add http api for nodes#344 (#371) * add http api for nodes * fix:bug * fix:bug * fix:bug * fix:bug * feat: add arana-admin into docker compose file * fix 🐛 HTTP API For UI (#399) * change * change * feat(config): support new config & Feat config listener (#374) * feat: add group api for UI module #344 (#373) * add: missing interfaces in proto files and discovery files * feat: group api in file db_groups.go (#344) * style: add license header and add tool: imports-formatter * style: fix import * feat: support notify event * refactor:config center * none * feat: none * refactor:split config and add change watch * style: fix code style * fix: fix func call error * fix: ci error * style:fix code style * fix: fix code style * refactor: rebase upstream * fix:add cluster info to list groups Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com> Co-authored-by: Jeffsky <jjeffcaii@outlook.com> * fix: compile failure * fix:unit test (#403) * Feat/admin api (#404) * Feat/admin api (#406) * fix:unit test * fix:unit test * fix:file unit test Co-authored-by: Zonglei Dong <dongzonglei@apache.org> Co-authored-by: Aphelios <996933971@qq.com> Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com> Co-authored-by: 龚娜 <2036479155@qq.com> Co-authored-by: liaochuntao <liaochuntao@live.com> Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
add missing interfaces && add group api
Which issue(s) this PR fixes:
ref #344