-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support new config & Feat config listener #374
Merged
jjeffcaii
merged 14 commits into
arana-db:feat/admin-api
from
chuntaojun:feat_config_listener
Sep 4, 2022
Merged
support new config & Feat config listener #374
jjeffcaii
merged 14 commits into
arana-db:feat/admin-api
from
chuntaojun:feat_config_listener
Sep 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mulavar
reviewed
Aug 23, 2022
Mulavar
reviewed
Aug 23, 2022
Mulavar
reviewed
Aug 23, 2022
Mulavar
approved these changes
Aug 23, 2022
chuntaojun
changed the title
(WIP) Feat config listener
support new config & Feat config listener
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
jjeffcaii
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fix
AlexStocks
reviewed
Aug 23, 2022
上述问题这两天会修复处理下,大家看看逻辑上是否有什么问题 |
dongzl
requested changes
Aug 23, 2022
chuntaojun
force-pushed
the
feat_config_listener
branch
from
August 28, 2022 04:20
18ff0be
to
04042a2
Compare
jjeffcaii
approved these changes
Aug 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dongzl
requested changes
Aug 29, 2022
chuntaojun
force-pushed
the
feat_config_listener
branch
from
September 3, 2022 03:52
acfff52
to
f51dd16
Compare
dongzl
approved these changes
Sep 3, 2022
jjeffcaii
force-pushed
the
feat/admin-api
branch
from
September 3, 2022 14:13
1113978
to
bce3f02
Compare
* add: missing interfaces in proto files and discovery files * feat: group api in file db_groups.go (arana-db#344) * style: add license header and add tool: imports-formatter * style: fix import
chuntaojun
force-pushed
the
feat_config_listener
branch
from
September 4, 2022 05:09
f51dd16
to
94c79a9
Compare
AlexStocks
approved these changes
Sep 4, 2022
AlexStocks
pushed a commit
that referenced
this pull request
Sep 10, 2022
* feat: add admin api server skeleton (#330) * feat(config): add config updater api (#336) * add http server api for cluster. (#352) * add http server api for tenant (#366) * add http server api for tenant * fix import format * fix go format Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com> * add http api for nodes#344 (#371) * add http api for nodes * fix:bug * fix:bug * fix:bug * fix:bug * feat: add arana-admin into docker compose file * fix 🐛 HTTP API For UI (#399) * change * change * feat(config): support new config & Feat config listener (#374) * feat: add group api for UI module #344 (#373) * add: missing interfaces in proto files and discovery files * feat: group api in file db_groups.go (#344) * style: add license header and add tool: imports-formatter * style: fix import * feat: support notify event * refactor:config center * none * feat: none * refactor:split config and add change watch * style: fix code style * fix: fix func call error * fix: ci error * style:fix code style * fix: fix code style * refactor: rebase upstream * fix:add cluster info to list groups Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com> Co-authored-by: Jeffsky <jjeffcaii@outlook.com> * fix: compile failure * fix:unit test (#403) * Feat/admin api (#404) * Feat/admin api (#406) * fix:unit test * fix:unit test * fix:file unit test Co-authored-by: Zonglei Dong <dongzonglei@apache.org> Co-authored-by: Aphelios <996933971@qq.com> Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com> Co-authored-by: 龚娜 <2036479155@qq.com> Co-authored-by: liaochuntao <liaochuntao@live.com> Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
ref #325 #327 #346
Special notes for your reviewer:
Does this PR introduce a user-facing change?: