Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new config & Feat config listener #374

Merged
merged 14 commits into from
Sep 4, 2022

Conversation

chuntaojun
Copy link
Contributor

@chuntaojun chuntaojun commented Aug 22, 2022

What this PR does:

Which issue(s) this PR fixes:

ref #325 #327 #346

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@chuntaojun chuntaojun changed the title Feat config listener (WIP) Feat config listener Aug 22, 2022
@dongzl dongzl added refactor Refactor code config Config center. labels Aug 23, 2022
@chuntaojun chuntaojun changed the title (WIP) Feat config listener support new config & Feat config listener Aug 23, 2022
pkg/boot/proto.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/compare.go Outdated Show resolved Hide resolved
pkg/config/default.go Outdated Show resolved Hide resolved
pkg/config/etcd/etcd.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

cmd/tools/tools.go Outdated Show resolved Hide resolved
@chuntaojun
Copy link
Contributor Author

上述问题这两天会修复处理下,大家看看逻辑上是否有什么问题

conf/bootstrap.yaml Outdated Show resolved Hide resolved
pkg/boot/discovery.go Outdated Show resolved Hide resolved
testdata/fake_bootstrap.yaml Outdated Show resolved Hide resolved
pkg/config/nacos/nacos.go Outdated Show resolved Hide resolved
pkg/config/model.go Outdated Show resolved Hide resolved
pkg/config/diff.go Outdated Show resolved Hide resolved
pkg/config/diff.go Outdated Show resolved Hide resolved
pkg/config/diff.go Outdated Show resolved Hide resolved
pkg/config/diff.go Outdated Show resolved Hide resolved
pkg/config/diff.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

conf/bootstrap.yaml Outdated Show resolved Hide resolved
testdata/fake_bootstrap.yaml Outdated Show resolved Hide resolved
jettcc and others added 2 commits September 4, 2022 12:38
* add: missing interfaces in proto files and discovery files

* feat: group api in file db_groups.go (arana-db#344)

* style: add license header and add tool: imports-formatter

* style: fix import
@jjeffcaii jjeffcaii merged commit 6ae534f into arana-db:feat/admin-api Sep 4, 2022
@dongzl dongzl removed the do not merge Do not merge label Sep 7, 2022
AlexStocks pushed a commit that referenced this pull request Sep 10, 2022
* feat: add admin api server skeleton (#330)

* feat(config): add config updater api (#336)

* add http server api for cluster. (#352)

* add http server api for tenant (#366)

* add http server api for tenant

* fix import format

* fix go format

Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com>

* add  http api for nodes#344 (#371)

* add  http api for nodes

* fix:bug

* fix:bug

* fix:bug

* fix:bug

* feat: add arana-admin into docker compose file

* fix 🐛  HTTP API For UI (#399)

* change

* change

* feat(config): support new config & Feat config listener (#374)

* feat: add group api for UI module #344 (#373)

* add: missing interfaces in proto files and discovery files

* feat: group api in file db_groups.go (#344)

* style: add license header and add tool: imports-formatter

* style: fix import

* feat: support notify event

* refactor:config center

* none

* feat: none

* refactor:split config and add change watch

* style: fix code style

* fix: fix func call error

* fix: ci error

* style:fix code style

* fix: fix code style

* refactor: rebase upstream

* fix:add cluster info to list groups

Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com>
Co-authored-by: Jeffsky <jjeffcaii@outlook.com>

* fix: compile failure

* fix:unit test (#403)

* Feat/admin api (#404)

* Feat/admin api (#406)

* fix:unit test

* fix:unit test

* fix:file unit test

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Aphelios <996933971@qq.com>
Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com>
Co-authored-by: 龚娜 <2036479155@qq.com>
Co-authored-by: liaochuntao <liaochuntao@live.com>
Co-authored-by: chovychan <51713304+chovychan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Config center. refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants