[arccon] Add optional dotnet wrapper to prevent first time use race condition #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ondition. The wrapper is only used on Unix environment and may be disabled when setting CMake variable ARCCON_NO_WRAPPER_FOR_DOTNET.
grospelliergilles
force-pushed
the
dev/gg-add-dotnet-wrapper-in-arccon
branch
from
e8db341 to
2bfd038
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
- Coverage 70.22% 70.20% -0.02%
==========================================
Files 2258 2258
Lines 162364 162362 -2
Branches 18703 18697 -6
==========================================
- Hits 114017 113989 -28
- Misses 41572 41599 +27
+ Partials 6775 6774 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper is only used on Unix environment and may be disabled when setting CMake variable
ARCCON_NO_WRAPPER_FOR_DOTNET.The race condition is described in dotnet/runtime#91987 and
dotnet/runtime#80619 and does not seems to be resolved in
.Net 6and.Net 8.