Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of CMake variable ARCANE_MSBUILD_EXEC in ArcaneSwigConfig.cmake.in #1830

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

grospelliergilles
Copy link
Member

This variable used the dotnet wrapper added in #1791, but it should use the real path of the executable because the wrapper is not installed.

@grospelliergilles grospelliergilles added bug Something isn't working arcane Arcane Component arcane:wrapping Arcane C#/python wrapping labels Dec 9, 2024
@grospelliergilles grospelliergilles self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.24%. Comparing base (304b757) to head (7ad3e3b).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   70.24%   70.24%   -0.01%     
==========================================
  Files        2263     2263              
  Lines      162812   162812              
  Branches    18767    18766       -1     
==========================================
- Hits       114363   114362       -1     
- Misses      41669    41672       +3     
+ Partials     6780     6778       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 1197b6c into main Dec 9, 2024
31 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-fix-bad-value-for-dotnet-in-swig branch December 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:wrapping Arcane C#/python wrapping arcane Arcane Component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant