Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Config Repository should use the contract #156

Closed
drbyte opened this issue Oct 7, 2019 · 0 comments · Fixed by #157
Closed

[2.x] Config Repository should use the contract #156

drbyte opened this issue Oct 7, 2019 · 0 comments · Fixed by #157
Assignees
@stancl
Labels
bug Something isn't working
Milestone
2.1.0

Comments

@drbyte
Copy link
Contributor

drbyte commented Oct 7, 2019

Describe the bug

use Illuminate\Config\Repository;
should use
use Illuminate\Contracts\Config\Repository;
in TenantDatabaseManagers, eg:
https://github.com/stancl/tenancy/blob/75f038877fcac875d8c3d3affc385eec348c6e5d/src/TenantDatabaseManagers/MySQLDatabaseManager.php#L5-L11

Version:

Tenancy v2.0
@drbyte drbyte added the bug Something isn't working label Oct 7, 2019
@stancl stancl added this to the 2.1.0 milestone Oct 7, 2019
@drbyte drbyte changed the title Config Repository should use the contract [2.x] Config Repository should use the contract Oct 7, 2019
@drbyte drbyte mentioned this issue Oct 7, 2019
Merged
stancl pushed a commit that referenced this issue Oct 8, 2019
@drbyte @stancl
Refactor Config\Repository dependencies to use Contract (#157)
14843b4 
Fixes #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stancl stancl

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

[2.x] Refactor Config\Repository dependencies to use Contract
2 participants
@drbyte @stancl