Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Refactor Config\Repository dependencies to use Contract #157

Merged
merged 1 commit into from
Oct 8, 2019
Merged

[2.x] Refactor Config\Repository dependencies to use Contract #157

merged 1 commit into from
Oct 8, 2019

Conversation

drbyte
Copy link
Contributor

@drbyte drbyte commented Oct 7, 2019

Fixes #156

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #157 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #157   +/-   ##
=========================================
  Coverage     89.37%   89.37%           
  Complexity      292      292           
=========================================
  Files            50       50           
  Lines           866      866           
=========================================
  Hits            774      774           
  Misses           92       92
Impacted Files Coverage Δ Complexity Δ
src/Features/TenantConfig.php 100% <ø> (ø) 9 <0> (ø) ⬇️
.../TenancyBootstrappers/RedisTenancyBootstrapper.php 100% <ø> (ø) 6 <0> (ø) ⬇️
...rc/TenantDatabaseManagers/MySQLDatabaseManager.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...nantDatabaseManagers/PostgreSQLDatabaseManager.php 100% <ø> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f0388...f6c7a68. Read the comment docs.

@drbyte drbyte changed the title Refactor Config\Repository dependencies to use Contract [2.x] Refactor Config\Repository dependencies to use Contract Oct 8, 2019
@stancl stancl merged commit 14843b4 into archtechx:2.x Oct 8, 2019
@drbyte drbyte deleted the config-contract branch October 9, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.x] Config Repository should use the contract
2 participants