Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rewards): enhance withdrawal of rewards developer experience #502

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

fdymylja
Copy link
Contributor

@fdymylja fdymylja commented Nov 8, 2023

No description provided.

@fdymylja fdymylja changed the title feat(rewards) enhance withdrawal of rewards developer experience feat(rewards): enhance withdrawal of rewards developer experience Nov 21, 2023
@fdymylja fdymylja marked this pull request as ready for review November 21, 2023 10:19
@fdymylja fdymylja requested a review from a team as a code owner November 21, 2023 10:19
@fdymylja fdymylja requested a review from spoo-bar November 21, 2023 10:19
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fb311ca) 66.00% compared to head (19a14b1) 66.02%.
Report is 1 commits behind head on main.

Files Patch % Lines
x/rewards/keeper/distribution.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   66.00%   66.02%   +0.01%     
==========================================
  Files          63       63              
  Lines        3901     3909       +8     
==========================================
+ Hits         2575     2581       +6     
- Misses       1199     1200       +1     
- Partials      127      128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to be merged with current changes on main and conflicts resolved...

Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
@fdymylja fdymylja merged commit 1046cae into main Nov 24, 2023
8 of 9 checks passed
@fdymylja fdymylja deleted the fd/withdrawal_ux branch November 24, 2023 14:49
spoo-bar pushed a commit that referenced this pull request Jan 22, 2024
* add proto files and backwards compat test

* add changes + tests to distribution

* lint

* CHANGELOG.md

---------

Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
spoo-bar added a commit that referenced this pull request Jan 23, 2024
* refactor(x/rewards): move state to use collections (#475)

* state works in a backwards compatible manner

* migrate contract metadata to use collections

* move params in a backwards compatible way

* move params to use collections

* flat fees moved in backwards compatible way

* move flat fees fully to use collections

* flat fee keys cleanup

* move min cons fee in a non state breaking way

* move min cons fee to use collections fully

* cleanup keys.go

* move blockrewards to collections in a state compatible way

* move genesis to use collections

* move more code to use collections

* remove more code

* move DeleteBLockRewardsCascade from State to Keeper

* move tx rewards to collections in a safe way

* more of TxRewards state moved to collections

* fully migrate TxRewards to collections

* checkpoint

* remove GetRewardsByRewardAddr in state_rewards_record.go

* remove CreateRewardsRecord in state_rewards_record.go

* remove more from state_rewards_record.go

* tmp commit

* remove all unneeded things

* finalise fast removal

* fix prefix and cleanup

* lint fully + CHANGELOG.md

* address nits

* feat(rewards): enhance withdrawal of rewards developer experience (#502)

* add proto files and backwards compat test

* add changes + tests to distribution

* lint

* CHANGELOG.md

---------

Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>

* docs: ADR-008 – Improvements on rewards withdrawal experience. (#462)

* add withdrawal ux improvements adr

* Update ADR-008-withdrawal-ux-improvements.md

Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>

* Update CHANGELOG.md

---------

Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Co-authored-by: Spoorthi Satheesha <9302666+spoo-bar@users.noreply.github.com>

* running swagger gen

---------

Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants