-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cherrypicking withdrawl enhancements to v6 #535
feat: cherrypicking withdrawl enhancements to v6 #535
Conversation
* state works in a backwards compatible manner * migrate contract metadata to use collections * move params in a backwards compatible way * move params to use collections * flat fees moved in backwards compatible way * move flat fees fully to use collections * flat fee keys cleanup * move min cons fee in a non state breaking way * move min cons fee to use collections fully * cleanup keys.go * move blockrewards to collections in a state compatible way * move genesis to use collections * move more code to use collections * remove more code * move DeleteBLockRewardsCascade from State to Keeper * move tx rewards to collections in a safe way * more of TxRewards state moved to collections * fully migrate TxRewards to collections * checkpoint * remove GetRewardsByRewardAddr in state_rewards_record.go * remove CreateRewardsRecord in state_rewards_record.go * remove more from state_rewards_record.go * tmp commit * remove all unneeded things * finalise fast removal * fix prefix and cleanup * lint fully + CHANGELOG.md * address nits
* add proto files and backwards compat test * add changes + tests to distribution * lint * CHANGELOG.md --------- Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
* add withdrawal ux improvements adr * Update ADR-008-withdrawal-ux-improvements.md Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> * Update CHANGELOG.md --------- Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> Co-authored-by: Spoorthi Satheesha <9302666+spoo-bar@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## releases/6.x.x #535 +/- ##
=================================================
Coverage ? 65.90%
=================================================
Files ? 64
Lines ? 3916
Branches ? 0
=================================================
Hits ? 2581
Misses ? 1207
Partials ? 128 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please consider a local test before we release to Titus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Cherrypicking the three relevant PRs regarding withdrawl enhancements
Regenerating swagger file as there are proto changes now