Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version #4

Closed
azdanov opened this issue Nov 23, 2018 · 2 comments · Fixed by #5
Closed

Update to latest version #4

azdanov opened this issue Nov 23, 2018 · 2 comments · Fixed by #5

Comments

@azdanov
Copy link
Contributor

azdanov commented Nov 23, 2018

There is a modern-normalize.css version 0.5.0. And styled-components version 4.1.1 for peer dependency.

Would a PR be welcome with a version bump?

@arcticicestudio
Copy link
Owner

arcticicestudio commented Nov 24, 2018

That would be great 👍
I've also added it to my TODOs, but the list is actually to long and there are more urgent tasks.
If you'd like to submit a PR please take care of all changes made since v0.4.0 (maybe one commit per change for better overview in logs?) and replace styled-components deprecated (v3) injectGlobal function with the really nice and new createglobalstyle component factory function introduced in v4. I think the docs should not mention both functions for something like legacy or backwards compatibility since there should be absolute no reason why someone might stay on v3. Also the official styled-components docs provide a migration guide that explains how to update so this is covered.

@arcticicestudio
Copy link
Owner

Resolved in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@azdanov @arcticicestudio and others