-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to modern-normalize@0.5.0 #5
Conversation
This commit updates to the latest upstream version `modern-normalize@0.5.0` (1) with the folloing changes: - Removed moot correction of `h1` font size and margin -> sindresorhus/modern-normalize#23 -> sindresorhus/modern-normalize@ddfe74ac - Prevent adjustments of font size after orientation changes in iOS -> sindresorhus/modern-normalize#28 -> sindresorhus/modern-normalize@30f4acd4f - Remove `details` normalization, update `summary` requirement -> sindresorhus/modern-normalize#21 -> sindresorhus/modern-normalize@2dc54f8e References: (1) https://github.com/sindresorhus/modern-normalize/releases/tag/v0.5.0 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> GH-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping the project with your contribution 👍
The changes for modern-normalize@0.5.0
looking good, but there are some changes that are not related to #4. Mixing many changes into one PR will reduce the transparency of changes due to missing issue references.
The update to styled-components v4 should be made in a separate PR since it is not required by modern-normalize. To not loose your already altered code I'll extract your related commits for this change into a new PR. Also it is not the goal of this package to force users to use v4 and with that the new component-based styles. It'll break all users that rely on composing the provided CSS with other styles making it impossible to override specific parts of it. We want to only export the styles as interpolated strings, users can then simply create a ModernNormalize
component on their own or use the v3 injectGlobal
function if they don't want or can't update to v4 yet.
Bumping the version to 1.0.0
would mean it is in production state which is not the case since the upstream project it provides is in development state too (0.5.0 < 1.0.0
). Making breaking changes it totally fine when in major version zero 0.x.x
:
- Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.
One commit also includes a bug fix for the documentation (URL of the badge in the changelog) so I'll extract that commit too into a separate issue.
The actual changes for the upstream update are fine, I'll force push this PR, extract the mentioned commits, merge it and keep you updated for the new PR and bug fix issue.
Thanks again for your help 🚀
Thanks for explaining how to do a better PR! Will definitely do more granular PR's in the future and be careful with version numbers (didn't know about |
Your commits are totally fine (saw the prefixes with the scope like docs and the target often in other projects), but it is really easier to split changes up into separate issues (because why not, doesn't cost any cent 😄 ). I've already created #6 and resolved + merged it in #7 so the update to styled-components v4 is done. |
Due to breaking changes I've had to bump version to
1.0.0
since css is no longer exported.Maybe add css only export as a named export to allow composition for stylesheets? But I think it's not needed.
I've updated all dependencies, linted and fixed files, updated readme and changelog.
Are any changes necessary?