Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for styled-components v4 #6

Closed
arcticicestudio opened this issue Dec 1, 2018 · 0 comments
Closed

Support for styled-components v4 #6

arcticicestudio opened this issue Dec 1, 2018 · 0 comments

Comments

@arcticicestudio
Copy link
Owner

arcticicestudio commented Dec 1, 2018

Related to #4
Implemented by @azdanov in PR #5

styled-components v4 has recently been released. Details about new awesome features and performance boosts can be found in the blog post, the changelog and the migration guide.
There is now a new way to use global styles via the createGlobalStyle factory API function that returns a React.Component instead of injecting it directly like in v3 with injectGlobalStyle.

To support v4, instructions will be added to the documentation how to use it with this project. We won't change the currently exported interpolated styles to export a React component since this won't allows users to compose or override the styles and would force them to use the component as it is. It would also break the usage with v3 or lower. Users who like to use the new component-based approach can simply create a new styeled component with the new createGlobalStyle API and inject the styles imported from this library, allowing them to adjust and modify it to fit their needs.

@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Dec 1, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 1, 2018
arcticicestudio added a commit that referenced this issue Dec 1, 2018
Updated the peer dependency for styled-components v4 while keeping the
compatibility with v3 or lower.

Co-authored-by: Anton Zdanov <azdanov@pm.me>
GH-6
arcticicestudio added a commit that referenced this issue Dec 1, 2018
Co-authored-by: Anton Zdanov <azdanov@pm.me>
GH-6
arcticicestudio added a commit that referenced this issue Dec 1, 2018
…d-components-v4

Support styled components v4
@arcticicestudio arcticicestudio removed their assignment Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant