Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #3594

Closed
wants to merge 1 commit into from
Closed

test #3594

wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Sep 27, 2021

these changes allow key and args functions to return promises, which may be helpful if ExternalObject access were to be managed by a store -- in which case the store could be updated even after initial result returned from original schema either with additional incremental delivery results or with results from other schemas.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2021

⚠️ No Changeset found

Latest commit: c2146cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-tools/Ho5RTftMTyfeMpXfhf8WZeq8V2Cz
✅ Preview: https://graphql-tools-git-lazy-experiment-theguild.vercel.app

@theguild-bot
Copy link
Collaborator

theguild-bot commented Sep 27, 2021

The latest changes of this PR are not available as alpha, since there are no linked changesets for this PR.

@yaacovCR
Copy link
Collaborator Author

Perhaps predictably, not so great performance wise.

@yaacovCR yaacovCR closed this Sep 27, 2021
@yaacovCR
Copy link
Collaborator Author

although not as much of a performance penalty as the other approach.... @ardatan any thoughts on these numbers?

this approach could also help with defer/stream

may be helpful if ExternalObject access were to be managed by a store -- in which case the store could be updated after initial result returned from original schema either with additional incremental delivery results or with results from other schemas
@ardatan ardatan force-pushed the master branch 5 times, most recently from d34fb65 to b8bf584 Compare August 11, 2024 23:45
@yaacovCR
Copy link
Collaborator Author

yaacovCR commented Oct 9, 2024

Closing this very stale pull request.

@yaacovCR yaacovCR closed this Oct 9, 2024
@yaacovCR yaacovCR deleted the lazy-experiment branch October 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants