Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid polluting the original object in case of Object.create #1797

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Nov 13, 2024

See #1796

Copy link
Contributor

github-actions bot commented Nov 13, 2024

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=138.713791 min=45     med=138     max=189      p(90)=164     p(95)=171    
     data_received..................: 22 MB  746 kB/s
     data_sent......................: 15 MB  483 kB/s
     http_req_blocked...............: avg=3.04µs     min=641ns  med=1.36µs  max=10.33ms  p(90)=1.95µs  p(95)=2.21µs 
     http_req_connecting............: avg=1.25µs     min=0s     med=0s      max=5.4ms    p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.44ms    min=2.67ms med=19.83ms max=978.32ms p(90)=26.05ms p(95)=28.86ms
       { expected_response:true }...: avg=20.44ms    min=2.67ms med=19.83ms max=978.32ms p(90)=26.05ms p(95)=28.86ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 146207
     http_req_receiving.............: avg=33.92µs    min=9.36µs med=23.9µs  max=15.99ms  p(90)=38.88µs p(95)=46.08µs
     http_req_sending...............: avg=10.98µs    min=3.44µs med=6.62µs  max=22.22ms  p(90)=9.83µs  p(95)=13.23µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.4ms     min=2.65ms med=19.79ms max=978.2ms  p(90)=26ms    p(95)=28.77ms
     http_reqs......................: 146207 4872.605449/s
     iteration_duration.............: avg=41ms       min=14.9ms med=39.3ms  max=1s       p(90)=47.22ms p(95)=51.46ms
     iterations.....................: 73090  2435.852813/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Nov 13, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/server 0.9.55-alpha-20241113152551-99dc2fae1faa31a67535d6376eb19f716c02dca8 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Nov 13, 2024

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=138.829278 min=14      med=138     max=200     p(90)=160     p(95)=168    
     data_received..................: 22 MB  718 kB/s
     data_sent......................: 14 MB  460 kB/s
     http_req_blocked...............: avg=2.59µs     min=641ns   med=1.37µs  max=8.15ms  p(90)=2.07µs  p(95)=2.42µs 
     http_req_connecting............: avg=632ns      min=0s      med=0s      max=3.92ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.24ms    min=3.01ms  med=20.48ms max=1.13s   p(90)=26.71ms p(95)=29.14ms
       { expected_response:true }...: avg=21.24ms    min=3.01ms  med=20.48ms max=1.13s   p(90)=26.71ms p(95)=29.14ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 140752
     http_req_receiving.............: avg=36.51µs    min=9.77µs  med=24.94µs max=30.01ms p(90)=39.37µs p(95)=46.55µs
     http_req_sending...............: avg=11.94µs    min=3.25µs  med=6.62µs  max=22.62ms p(90)=10.15µs p(95)=14.15µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.19ms    min=2.98ms  med=20.44ms max=1.13s   p(90)=26.65ms p(95)=29.04ms
     http_reqs......................: 140752 4691.159036/s
     iteration_duration.............: avg=42.59ms    min=11.16ms med=41ms    max=1.15s   p(90)=47.62ms p(95)=53.04ms
     iterations.....................: 70366  2345.246226/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Nov 13, 2024

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 296646      ✗ 0     
     data_received..................: 29 MB   974 kB/s
     data_sent......................: 12 MB   396 kB/s
     http_req_blocked...............: avg=1.4µs    min=901ns   med=1.21µs   max=293.97µs p(90)=1.9µs    p(95)=2.08µs  
     http_req_connecting............: avg=0ns      min=0s      med=0s       max=118.44µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=141.09µs min=93.49µs med=135.02µs max=9.64ms   p(90)=158.23µs p(95)=166.25µs
       { expected_response:true }...: avg=141.09µs min=93.49µs med=135.02µs max=9.64ms   p(90)=158.23µs p(95)=166.25µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 148323
     http_req_receiving.............: avg=24.45µs  min=12.23µs med=23.2µs   max=1.86ms   p(90)=30.46µs  p(95)=32.72µs 
     http_req_sending...............: avg=6.25µs   min=4.02µs  med=5.46µs   max=2.59ms   p(90)=8.09µs   p(95)=8.76µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=110.38µs min=69.2µs  med=103.91µs max=9.54ms   p(90)=123.79µs p(95)=130.74µs
     http_reqs......................: 148323  4943.906847/s
     iteration_duration.............: avg=197.89µs min=136.5µs med=190.76µs max=10.28ms  p(90)=217.2µs  p(95)=227.86µs
     iterations.....................: 148323  4943.906847/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Nov 13, 2024

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 218520      ✗ 0     
     data_received..................: 22 MB   732 kB/s
     data_sent......................: 8.7 MB  291 kB/s
     http_req_blocked...............: avg=1.41µs   min=891ns    med=1.22µs   max=179.95µs p(90)=1.88µs   p(95)=2.05µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=118.68µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=212.77µs min=159.95µs med=199.43µs max=41.9ms   p(90)=225.32µs p(95)=238.3µs 
       { expected_response:true }...: avg=212.77µs min=159.95µs med=199.43µs max=41.9ms   p(90)=225.32µs p(95)=238.3µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 109260
     http_req_receiving.............: avg=25.64µs  min=13.87µs  med=24.25µs  max=8.81ms   p(90)=31.24µs  p(95)=33.3µs  
     http_req_sending...............: avg=6.36µs   min=4.12µs   med=5.66µs   max=323.75µs p(90)=8.11µs   p(95)=8.6µs   
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=180.75µs min=129.95µs med=167.37µs max=41.79ms  p(90)=189.94µs p(95)=202.22µs
     http_reqs......................: 109260  3641.886728/s
     iteration_duration.............: avg=270.19µs min=210.65µs med=255.99µs max=42.01ms  p(90)=285.42µs p(95)=301.55µs
     iterations.....................: 109260  3641.886728/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Nov 13, 2024

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 233892      ✗ 0     
     data_received..................: 24 MB   784 kB/s
     data_sent......................: 9.4 MB  312 kB/s
     http_req_blocked...............: avg=1.42µs   min=911ns    med=1.22µs   max=178.2µs  p(90)=1.91µs   p(95)=2.07µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=120.35µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=194.97µs min=145.54µs med=182.76µs max=38.43ms  p(90)=208.42µs p(95)=221.92µs
       { expected_response:true }...: avg=194.97µs min=145.54µs med=182.76µs max=38.43ms  p(90)=208.42µs p(95)=221.92µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 116946
     http_req_receiving.............: avg=25.32µs  min=13.11µs  med=24.1µs   max=2.81ms   p(90)=31.01µs  p(95)=33.01µs 
     http_req_sending...............: avg=6.33µs   min=4.11µs   med=5.59µs   max=331.05µs p(90)=8.14µs   p(95)=8.7µs   
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=163.31µs min=117.88µs med=151.01µs max=38.35ms  p(90)=173.43µs p(95)=186.28µs
     http_reqs......................: 116946  3898.069152/s
     iteration_duration.............: avg=252.05µs min=193µs    med=238.99µs max=38.57ms  p(90)=268.57µs p(95)=285.19µs
     iterations.....................: 116946  3898.069152/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit 39da7bb into master Nov 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants