-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: context properties are shared between batched requests #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcee059 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://d89a74f0.graphql-yoga.pages.dev |
✅ Benchmark Results
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
n1ru4l
force-pushed
the
fix-batching-context-identity
branch
from
November 14, 2024 10:06
6517f1a
to
97fdef0
Compare
n1ru4l
changed the title
test: context properties are shared between
fix: context properties are shared between batched requests
Nov 14, 2024
ardatan
approved these changes
Nov 14, 2024
n1ru4l
force-pushed
the
fix-batching-context-identity
branch
from
November 14, 2024 10:12
4198466
to
b211d06
Compare
n1ru4l
force-pushed
the
fix-batching-context-identity
branch
from
November 14, 2024 10:20
4142059
to
74d13c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an issue for usage reporting for batched requests, I realized that context assignments for one batch execution to one context are also shared/assigned to the other batch contexts.
Object.create
creates a new object using the existing object as the prototype so the assignments seem to be inherited. 🫤This bug was introduced in #3270This bug originates from
@whatwg-node/server
See ardatan/whatwg-node#1797 and ardatan/whatwg-node#1796).