Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults stack to default OS value to avoid inadvertent overflow #882

Merged
merged 2 commits into from
May 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libraries/Scheduler/src/Scheduler.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ extern "C" {
typedef void (*SchedulerParametricTask)(void *);
}

// This class exists for only backwards compatibility with arduino-libraries/Scheduler.
// You are encorraged to use mbed::Thread directly rather than using this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here 🙂

class SchedulerClass {
public:
SchedulerClass();
void startLoop(SchedulerTask task, uint32_t stackSize = 1024);
void start(SchedulerTask task, uint32_t stackSize = 1024);
void start(SchedulerParametricTask task, void *data, uint32_t stackSize = 1024);
void startLoop(SchedulerTask task, uint32_t stackSize = OS_STACK_SIZE);
void start(SchedulerTask task, uint32_t stackSize = OS_STACK_SIZE);
void start(SchedulerParametricTask task, void *data, uint32_t stackSize = OS_STACK_SIZE);

void yield() { ::yield(); };
private:
Expand Down
Loading