-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-changelog] Migrate tests from test_profiles.py
to profiles_test.go
#1858
Conversation
Codecov ReportBase: 36.66% // Head: 36.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
+ Coverage 36.66% 36.77% +0.10%
==========================================
Files 231 231
Lines 19689 19689
==========================================
+ Hits 7219 7240 +21
+ Misses 11642 11624 -18
+ Partials 828 825 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
test_profiles.py
to profiles_test.go
2833bea
to
35b7cb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umbynos I decided to simply copy them because I did not know if there were other tests using those sketches. Removing all of the sketches when there would have been no more tests to rewrite seemed safer. |
It's the same for me, but they are not used in any other test 🛩️ |
35b7cb4
to
db6897a
Compare
…t.go and delete test_profiles.py
db6897a
to
5eae5de
Compare
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure Enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_profiles.py
have been rewritten inprofiles_test.go
, without changing their original purpose.The tests are the following:
Does this PR introduce a breaking change, and is titled accordingly?
No
See how to contribute