Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Migrate tests from test_profiles.py to profiles_test.go #1858

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Sep 1, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure Enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_profiles.py have been rewritten in profiles_test.go, without changing their original purpose.
The tests are the following:

  • TestCompileWithProfiles
  • TestBuilderDidNotCatchLibsFromUnusedPlatforms

Does this PR introduce a breaking change, and is titled accordingly?

No


See how to contribute

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 1, 2022
@MatteoPologruto MatteoPologruto self-assigned this Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 36.66% // Head: 36.77% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (5eae5de) compared to base (87d2efa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
+ Coverage   36.66%   36.77%   +0.10%     
==========================================
  Files         231      231              
  Lines       19689    19689              
==========================================
+ Hits         7219     7240      +21     
+ Misses      11642    11624      -18     
+ Partials      828      825       -3     
Flag Coverage Δ
unit 36.77% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go 83.15% <0.00%> (+3.29%) ⬆️
arduino/monitor/monitor.go 47.36% <0.00%> (+6.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPologruto MatteoPologruto changed the title [skip-changelog] Migrate tests from test_profiles.py to profiles_test.go [skip-changelog] Migrate tests from test_profiles.py to profiles_test.go Sep 1, 2022
@MatteoPologruto MatteoPologruto marked this pull request as ready for review September 2, 2022 12:40
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatteoPologruto
Copy link
Contributor Author

MatteoPologruto commented Sep 2, 2022

I'd also remove https://github.com/arduino/arduino-cli/blob/f0245bc2da6a56fccea7b2c9ea09e85fdcc52cb8/test/testdata/sketch_with_profile/ and https://github.com/arduino/arduino-cli/blob/f0245bc2da6a56fccea7b2c9ea09e85fdcc52cb8/test/testdata/sketch_with_error_including_wire

@umbynos I decided to simply copy them because I did not know if there were other tests using those sketches. Removing all of the sketches when there would have been no more tests to rewrite seemed safer.

@umbynos
Copy link
Contributor

umbynos commented Sep 2, 2022

It's the same for me, but they are not used in any other test 🛩️

@MatteoPologruto
Copy link
Contributor Author

MatteoPologruto commented Sep 13, 2022

@MatteoPologruto MatteoPologruto merged commit a3f6574 into master Sep 20, 2022
@MatteoPologruto MatteoPologruto deleted the profile-test-go branch September 20, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants