-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC testsuite #1806
Add gRPC testsuite #1806
Conversation
https://github.com/arduino/arduino-cli/runs/7356179761?check_suite_focus=true#step:7:1328 this is an real bug that the testsuite is triggering |
b650e9d
to
c6cfe21
Compare
Codecov Report
@@ Coverage Diff @@
## master #1806 +/- ##
==========================================
+ Coverage 35.50% 36.27% +0.77%
==========================================
Files 230 232 +2
Lines 19532 19497 -35
==========================================
+ Hits 6934 7073 +139
+ Misses 11773 11594 -179
- Partials 825 830 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR has currently evolved:
|
ac27b0c
to
6601e97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Cristian. Thanks!
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Draft of a gRPC test-suite.
There are helper functions to:
I've put everything inside the
internal
package, but I see that some of those objects may be part of a more general-purpose library (like thetestsuite.Environment
object may be potentially reused in other projects.This implementation has some overlap with our current integration tests in python. As I see it, it has the potential to completely replace pytest if we properly expand it.
Does this PR introduce a breaking change, and is titled accordingly?
No