[skip-changelog] Migrate tests from test_config.py to config_test.go
#1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov ReportBase: 36.65% // Head: 36.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 36.65% 36.61% -0.05%
==========================================
Files 231 231
Lines 19683 19683
==========================================
- Hits 7215 7206 -9
- Misses 11640 11648 +8
- Partials 828 829 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MatteoPologruto
force-pushed
the
config-test-go
branch
from
9c04d90 to
7e055fd
Compare
|
Converting this PR back to drafting stage since |
MatteoPologruto
force-pushed
the
config-test-go
branch
from
7e055fd to
4e3aec2
Compare
|
The content of PR #1902 has been migrated. |
cmaglie
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_config.pyhave been rewritten inconfig_test.go, without changing their original purpose.More informations on the tests can be found checking the single commits.
Does this PR introduce a breaking change, and is titled accordingly?
No
See how to contribute