Use goreleaser to build the full binary matrix #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
previously requested changes
Jul 30, 2019
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
gvarisco
approved these changes
Jul 30, 2019
|
|
||
| ## Legal requirements | ||
|
|
||
| Before we can accept your contributions you have to sign the [Contributor License Agreement][0] |
There was a problem hiding this comment.
are we going to use cla-assistant for it, isn't it?
There was a problem hiding this comment.
yup, already in place, included Github integration
rsora
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Dockerfile used to build an image capable to cross compile the CLI for all the supported platforms:
NOTE this is highly WIP work, because of https://bugs.launchpad.net/ubuntu/+source/gcc-defaults/+bug/1300211 the image doesn't work ootb. Currently trying to build from https://github.com/multiarch/crossbuild instead ofgolang-cross.This PR supersedes #120 and partially #132 (the binary provided is static for any platform except Darwin)
TODO: