Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use goreleaser to build the full binary matrix #311

Merged
merged 12 commits into from
Jul 31, 2019
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 41 additions & 5 deletions .drone.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
---
kind: pipeline
name: default
name: test

steps:
- name: lint
image: arduino/arduino-cli:drone-1.0
commands:
# Check if the Go code is properly formatted and run the linter
- task check
# Ensure protobufs compile
# Ensure protobufs compile without errors
- task protoc

- name: build
Expand All @@ -27,10 +28,10 @@ steps:
- pip install -r test/requirements.txt
- task test-integration

# Contrary to other CI platforms, uploading reports to Codecov requires Drone to provide a token.
# To avoid exposing the Codecov token to external PRs, we only upload coverage when we merge on
# `master`.
- name: coverage
# Contrary to other CI platforms, uploading reports to Codecov requires Drone to provide a token.
# To avoid exposing the Codecov token to external PRs, we only upload coverage when we merge on
# `master`.
image: arduino/arduino-cli:drone-1.0
environment:
CODECOV_TOKEN:
Expand All @@ -43,3 +44,38 @@ steps:
- master
event:
- push

---
kind: pipeline
name: release

steps:
- name: fetch
# extra step needed to fetch tags after cloning
image: docker:git
commands:
- git fetch --tags

- name: release
image: arduino/arduino-cli:builder-0.1
environment:
GITHUB_TOKEN:
from_secret: github_token
commands:
- goreleaser

trigger:
event:
# releases are triggered by tags only
- tag
status:
# skip the release if the previous build failed
- success
ref:
exclude:
# exclude the tags used to build Docker images for drone
- refs/tags/builder-*
- refs/tags/drone-*

depends_on:
- test
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ coverage_*.txt
__pycache__
venv
.pytest_cache
/dist
94 changes: 94 additions & 0 deletions .goreleaser.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
# Global section
checksum:
name_template: 'checksums.txt'

snapshot:
name_template: "{{ .Tag }}-next"

changelog:
sort: asc
filters:
exclude:
- '^[skip changelog]'

# We have multiple builds in order to fine tune
# cross compilations.
builds:
-
# OSX
id: arduino_cli_osx
binary: arduino-cli
env:
- CGO_ENABLED=1
- CXXFLAGS="-mmacosx-version-min=10.10"
- CC=/usr/x86_64-apple-darwin14/bin/cc
goos:
- darwin
goarch:
- amd64
ldflags:
- -s -w -X github.com/arduino/arduino-cli/version.versionString={{.Tag}} -X github.com/arduino/arduino-cli/version.commit=={{ .ShortCommit }}
-
# ARM
id: arduino_cli_arm
binary: arduino-cli
env:
- CGO_ENABLED=1
- CC=/usr/arm-linux-gnueabihf/bin/cc
goos:
- linux
goarch:
- arm
goarm:
- 7
ldflags:
- -s -w -X github.com/arduino/arduino-cli/version.versionString={{.Tag}} -X github.com/arduino/arduino-cli/version.commit=={{ .ShortCommit }}
- "-extldflags '-static'"
-
# ARM64
id: arduino_cli_arm64
binary: arduino-cli
env:
- CGO_ENABLED=1
- CC=/usr/aarch64-linux-gnu/bin/cc
goos:
- linux
goarch:
- arm64
ldflags:
- -s -w -X github.com/arduino/arduino-cli/version.versionString={{.Tag}} -X github.com/arduino/arduino-cli/version.commit=={{ .ShortCommit }}
- "-extldflags '-static'"
-
# All the other platforms
id: arduino_cli
binary: arduino-cli
env:
- CGO_ENABLED=0
goos:
- linux
- windows
goarch:
- amd64
- 386
ldflags:
- -s -w -X github.com/arduino/arduino-cli/version.versionString={{.Tag}} -X github.com/arduino/arduino-cli/version.commit=={{ .ShortCommit }}
- "-extldflags '-static'"

archives:
-
id: "arduino_cli"
format: tar.gz
format_overrides:
- goos: windows
format: zip
replacements:
amd64: 64bit
darwin: macOS
386: 32bit
arm: ARM
arm64: ARM64
linux: Linux
windows: Windows
files:
- README.md
- LICENSE.txt
142 changes: 142 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
# How to contribute

First of all, thanks for contributing!

This document provides some basic guidelines for contributing to this repository. To propose
improvements or fix a bug, feel free to submit a PR.

## Legal requirements

Before we can accept your contributions you have to sign the [Contributor License Agreement][0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to use cla-assistant for it, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, already in place, included Github integration


## Prerequisites

To build the Arduino CLI from sources you need the following tools to be available in your local
enviroment:

* [Go][1] version 1.12 or later
* [Taskfile][2] to help you run the most common tasks from the command line

If you want to run integration tests you will also need:

* A serial port with an Arduino device attached
* A working [Python][3] environment, version 3.5 or later

## Building the source code

From the project folder root, just run:

```shell
task build
```

The project uses Go modules so dependencies will be downloaded automatically, you should end with
an `arduino-cli` executable in the same folder.

## Running the tests

There are several checks and test suites in place to ensure the code works as expected but also it
is written in a way that's consistent across the whole codebase. Such tests can be run one after
another by running the command:

```shell
task test
```

If you want to only run unit tests and skip other checks, you can run:

```shell
task test-unit
```

Similarly, if you're only interested in running integration tests, you can do (be sure to read the
part dedicated to integration tests if something doesn't work):

```shell
task test-integration
```

### Integration tests

Being a command line interface, Arduino CLI is heavily interactive and it has to stay consistent
in accepting the user input and providing the expected output and proper exit codes. On top of this,
many Arduino CLI features involve communicating with external devices, most likely through a serial
port, so unit tests can only put our confidence that the code is working so far.

For these reasons, in addition to regular unit tests the project has a suite of integration tests
that actually run Arduino CLI in a different process and assess the options are correctly
understood and the output is what we expect.

To run the full suite of integration tests you need an Arduino device attached to a serial port and
a working Python environment. Chances are that you already have Python installed in your system, if
this is not the case you can [download][3] the official distribution or use the package manager
provided by your Operating System.

Some dependencies need to be installed before running the tests and to avoid polluting your global
Python enviroment with dependencies that might be only used by the Arduino CLI, you can use a
[virtual environment][4]. There are many ways to manage virtual environments, for example you can
use a productivity tool called [hatch][5]. First you need to install it (you might need to `sudo`
the following command):

```shell
pip3 install --user hatch
```

Then you can create a virtual environment to be used while working on Arduino CLI:

```shell
hatch env arduino-cli
```

At this point the virtual environment was created and you need to make it active every time you
open a new terminal session with the following command:

```shell
hatch shell arduino-cli
```

From now on, every package installed by Python will be confined to the `arduino-cli` virtual
environment, so you can proceed installing the dependencies required with:

```shell
pip install -r test/requirements.txt
```

If the last step was successfull, you should be able to run the tests with:

```shell
task test-integration
```

## Pull Requests

In order to ease code reviews and have your contributions merged faster, here is a list of items
you can check before submitting a PR:

* Create small PRs that are narrowly focused on addressing a single concern.
* PR titles indirectly become part of the CHANGELOG so it's crucial to provide a good
record of **what** change is being made in the title; **why** it was made will go in the
PR description, along with a link to a GitHub issue if it exists.
* write tests for the code you wrote.
* open your PR against the `master` branch.
* Maintain **clean commit history** and use **meaningful commit messages**.
PRs with messy commit history are difficult to review and require a lot of work to be merged.
* Your PR must pass all CI tests before we will merge it. If you're seeing an error and don't think
it's your fault, it may not be! The reviewer will help you if there are test failures that seem
not related to the change you are making.

## Additional settings

If you need to push a commit that's only shipping documentation changes or example files, thus a
complete no-op for the test suite, please start the commit message with the string **[skip ci]**
to skip the build and give that slot to someone else who does need it.

If your PR doesn't need to be included in the changelog, please start the PR title with the string
**[skip changelog]**

[0]: https://cla-assistant.io/arduino/arduino-cli
[1]: https://golang.org/doc/install
[2]: https://taskfile.dev/#/installation
[3]: https://www.python.org/downloads/
[4]: https://docs.python.org/3/tutorial/venv.html
[5]: https://github.com/ofek/hatch
16 changes: 16 additions & 0 deletions Dockerfiles/builder/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
FROM multiarch/crossbuild

ENV PATH $PATH:/usr/local/go/bin

# Install tooling
ENV GORELEASER_VER 0.113.0
ENV GORELEASER_SHA 2379beebb6369b75ccead7f7a43269de700b51821feae3857701d106ed72bd63
ENV GOVER 1.12.7
RUN set -ex \
&& curl -o goreleaser.tar.gz -LO https://github.com/goreleaser/goreleaser/releases/download/v${GORELEASER_VER}/goreleaser_Linux_x86_64.tar.gz \
&& echo "$GORELEASER_SHA goreleaser.tar.gz" | sha256sum -c - || exit 1 \
&& tar -xzf goreleaser.tar.gz -C /usr/bin/ goreleaser \
&& rm goreleaser.tar.gz \
&& curl -LO https://dl.google.com/go/go${GOVER}.linux-amd64.tar.gz \
&& tar -C /usr/local -xzf go${GOVER}.linux-amd64.tar.gz \
&& rm go${GOVER}.linux-amd64.tar.gz
Loading