Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1054 Fixed widget lookup to eliminate duplicate tabs. #1085

Merged
merged 1 commit into from
Jun 22, 2022
Merged

#1054 Fixed widget lookup to eliminate duplicate tabs. #1085

merged 1 commit into from
Jun 22, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

Fixes duplicate editor tabs due to bogus widget identity comparison in the widget manager.

Change description

  • Removed @theia/editor-preview,
  • Patched opener options when repairing layout on start, and
  • Compare widget keys with deepEquals instead of string equal.

Other information

Closes #1054

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos requested review from fstasi and per1234 June 20, 2022 14:40
@kittaakos kittaakos marked this pull request as ready for review June 20, 2022 15:30
AlbyIanna
AlbyIanna approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code's fine to me.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 21, 2022
@per1234 per1234 linked an issue Jun 21, 2022 that may be closed by this pull request
IDE starts unexpectedly; sketch is not set as workspace root, menu items are missing #1044
Open
3 tasks
per1234
per1234 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1054 for me.

Thanks Akos!

fstasi
fstasi approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fixed widget lookup to eliminate duplicate tabs.
7051bc3 
 - Removed `@theia/editor-preview`,
 - Patched opener options when repairing layout on start, and
 - Compare widget keys with deepEquals instead of string equal.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos merged commit 84109e4 into main Jun 22, 2022
@kittaakos kittaakos deleted the #1054-deepEquals branch June 22, 2022 08:11
This was referenced Jul 14, 2022
Closed
Closed
@per1234 per1234 mentioned this pull request Jan 3, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@fstasi fstasi fstasi approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
4 participants
@kittaakos @fstasi @AlbyIanna @per1234