Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two tabs open for same file and won't close #1791

Closed
3 tasks done
ChariseWalraven opened this issue Dec 29, 2022 · 12 comments · Fixed by #1969
Closed
3 tasks done

Two tabs open for same file and won't close #1791

ChariseWalraven opened this issue Dec 29, 2022 · 12 comments · Fixed by #1969
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@ChariseWalraven
Copy link

ChariseWalraven commented Dec 29, 2022 •
edited by per1234
Loading

Describe the problem

I included a library via the menu and somehow this resulted in another tab opening for the same file. When I try to delete the file nothing happens. I've tried to move the sketch to some other folder and then open and that seems to work (after it renames the parent folder), but when I move it back to the original folder the new tab reappears.

I'm on Ubuntu 22.04.1 LTS and the latest stable version of the IDE shown on the website at the time of writing (2.0.3). I also tested on the latest nightly and it occurs there too.

If you need log files or something, please let me know.

image

To reproduce

I tried reproducing and couldn't. But the issue is still there, even when I open the project on the nightly build.

Expected behavior

Delete closes the tab. Or closing and reopening the ediitor...

Arduino IDE version

2.04-nightly-20221229

Operating system

Linux

Operating system version

22.04.1 LTS

Additional context

The fact that this occurs across builds and after moving things around makes me think this has something to do with some kind of cache or (sketch?) settings file somewhere, but I don't know for sure.

I also remember the save icon being on briefly. I have autosave on, so I'm not sure if this happened before or after the library was included.

Additional reports:

Related:

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@ChariseWalraven ChariseWalraven added the type: imperfection Perceived defect in any part of project label Dec 29, 2022
@roboter-basteln
Copy link

I have a similar issue, but I can't recall having dealt with libraries.
My details see https://arduino.stackexchange.com/questions/91777/how-to-get-rid-of-the-second-tab-in-arduino-ide-2

@per1234 per1234 added the topic: code Related to content of the project itself label Jan 2, 2023
@per1234
Copy link
Contributor

per1234 commented Jan 3, 2023

Thanks for your reports. Unfortunately, I have not been able to reproduce this fault via use patterns resembling those described here and in the associated reports.

I am aware of two use patterns that will result in a duplicate tabs fault:

Renaming a sketch file in a manner that only changes the case of the filename

Tracked at #482

I'm certain that bug is unrelated to the one reported here for the following reasons

Opening sketch in a very old version of Arduino IDE 2.x

  1. Start any recent version of Arduino IDE.
  2. Open a sketch.
  3. Select File > Quit from the Arduino IDE menus.
  4. Start Arduino IDE 2.0.0-beta.11.
    ⓘ The fault does not occur if you use 2.0.0-beta.12 or newer for this step. I did not bisect it down to the specific newest commit that can be used for this step and still produce the fault.
  5. Select File > Quit from the Arduino IDE menus.
  6. Start any recent version of Arduino IDE.

🐛 The editor will contain duplicate sketch tabs for the sketch you opened previously.

However, I'm not convinced this is the cause of the faults reported here. The reasons:

Workaround

The following procedure restores a sketch which is exhibiting the duplicate tabs fault as produced by either of the procedures described above:

  1. Press the Ctrl+Shift+P keyboard shortcut (Command+Shift+P for macOS users) to open the "Command Palette".
  2. Select the "View: Reset Workbench Layout" command from the menu.

Since I am not able to reproduce the fault via normal usage of Arduino IDE as reported in this issue, I was unable to verify this workaround works under those conditions.

@jrobert-gh
Copy link

I am seeing something similar with 'arduino-ide_nightly-20230104_macOS_64bit.dmg' on macOS Monterey: Selecting certain file tabs duplicates that tab. This behavior has been around earliest Arduino IDE v2.x revisions I've used.

I can delete either of the duplicates by clicking its 'x' in the Open Editors list, but only if the Open Editors list had been open when the duplicate was created. If the list wasn't open and I open it after the duplicate tab is created, the duplicate tab doesn't appear in the list and I can't delete it.

My code files consist of an .ino file, two .h files, and three .cpp files. Tab duplication seems to happen consistently with two of the .cpp files but not with any of the other four files. The three .cpp files are very similar to one another, having been written from the same template.

The first check-in of the .ino file was March 9, 2014; the project has been through nearly 9 years of Arduino IDE versions (plus Gnu Emacs used about equally).

There are non-code files in the same directory as well:
.uxf - drawing files
.ods - spreadsheet
.pdf
.txt, .lst - text files
.hex - Arduino loader files
.h~, .cpp~, .ino~ - backup files left by Emacs

I don't know what, if any, of the above details will be of any help, but I hope something will.

@kittaakos kittaakos self-assigned this Jan 17, 2023
@FernandoGarcia
Copy link

The same here:
https://forum.arduino.cc/t/ide-restarts-during-a-start/1081761/3

@GaryInSanDiego
Copy link

I repeatedly had the problem where the sketch file would be open in two tabs.
This is in Arduino IDE version 2.0.3

I suspect the problem is the sketch file was stored in a file path that was about 165 chars long. The IDE may not allow for path strings to be that long.

I moved the sketch folder for this sketch file to another location, and the file now opens up in a single tab.

@FernandoGarcia
Copy link

I don't think that the problem is the path since I have the same problem with default file.

Captura de tela de 2023-01-24 20 44 05

@per1234
Copy link
Contributor

per1234 commented Feb 2, 2023

I suspect the problem is the sketch file was stored in a file path that was about 165 chars long. The IDE may not allow for path strings to be that long.

Thanks for sharing this information @GaryInSanDiego! I just checked with a sketch in a path 247 characters long and unfortunately still couldn't reproduce the fault.

I moved the sketch folder for this sketch file to another location, and the file now opens up in a single tab.

An alternative explanation for this is that Arduino IDE stores data about the UI state associated with a given sketch project separately from the sketch files. That data is keyed to the sketch path. So if the bad duplicate tabs state is stored for the sketch at one path, when you move the sketch, you also disassociate it from that previous data and the IDE instead creates a new data entry for the project at that new location.

@GaryInSanDiego
Copy link

I agree the length of the path is not the cause of the problem.

The two tab problem appears to be fixed by moving the sketch folder to another folder.

After moving the folder, I opened Arduino IDE ver 2.0.3, and it opened with two new blank sketches with todays date (ie. sketch_feb2a.ino just like that pictured above).

I then opened the sketch file that I just moved, and it opened in a single tab.

The sketch file that I was working with was developed in Oct of 2021, and since then I have uninstalled and reinstalled both versions of the Arduino IDE (versions 1.8.57.0 and 2.0.3). I think they are now installed in C:\Program Files\WindowsApps on my Windows 10 computer.

@GaryInSanDiego
Copy link

I can reproduce the two tabs problem with an old sketch file called RGB_LED.ino (in the ELEGOO starter kit).

I compiled this using Arduino IDE version 1.* back on 8/20/2021.

Yesterday, I opened this RGB_LED.ino sketch using Arduino IDE version 2.0.3, and the IDE displays two tabs for the same sketch file. I clicked File/Save As, and saved the sketch to another directory with the name myRGB_LED.ino. The two tab problem persisted in this newly saved version.

I closed the IDE and used Windows 10 File Explorer to copy this sketch file to another folder. I opened this copied sketch file using Arduino IDE 2.0.3 and only one tab was displayed for the sketch file. I then used the File/Save As feature to save this sketch to a new name called myRGB_LED_ver2. The problem of having two tabs for the same sketch file came back.

  1. I noticed the IDE text editor remembers positions of highlighted text in both tabs.
  2. If you move the sketch file to a new folder using Windows 10 file explorer, the two tab problem goes away.
  3. If you use File/Save As to save the sketch file to another folder, two tabs for the same sketch file returns.

I suspect this may have something to do with the IDE editor remembering selected text positions in the sketch file. If there are two tabs, it remembers selected text in both tabs. I have not found where the IDE editor stores the editing info yet.

I did look at the folders/files in C:\Users\Name\AppData\Local\Temp and saw several folders for Arduino. I noticed when I compile a sketch, a sketch folder is produced in this Temp folder (with several sub-folders), which shows paths and file names.

@sterretjeToo
Copy link

sterretjeToo commented Feb 25, 2023 •
edited
Loading

I've found the following (seemingly) solid workaround.

If the main sketch file (let's call it A.ino in directory A) shows with a duplicate tab, the following steps remove the duplicate tab

  1. Create an additional tab with an ino file (let's call it B.ino); the tab can be left empty
  2. Reset the workbench layout as described earlier by @per1234

The duplicate tab for A.ino has disappeared.

  1. You can now remove B.ino (if not needed).

After removing B.ino and reseting the workbench layout again, the duplicate tab for A.ino does not appear again.

Posting to provide a workaround as well as that it might be a pointer for developers to the underlaying issue. It's the second time that I used this approach. The first time I was not sure what I exactly did (except for creating the additional ino file).

Note:
The sketch only consisted of a single ino file, no additional tabs for .h or .cpp or .ino

//Edit
Solution does not seem to need the second file to be a .ino; just encountered it again and added a .h tab.

@RocketmanJMP
Copy link

Any progress on this bug? I tried all of the above and am still getting a duplicate of an example sketch. I am using win7 and the IDE version 2.0.4.
Moving and renaming the sketch doesn't fix the issue nor does the F1 reset the workbench. I also tried deleting the C:\Users\xx\AppData\Roaming\arduino-ide and it always comes back double. The example sketch is IRremoteESP8266: IRsendProntoDemo

kittaakos pushed a commit that referenced this issue Mar 20, 2023
fix: incorrect editor widget key calculation
1a176aa 
to avoid duplicate editor tabs when opening a sketch with no previously
saved workbench layout

Closes #1791

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue Mar 20, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Mar 20, 2023
no-merge: added a preference to reproduce #1791
bd8e66d 
the smaller the timeout the better chance you have to see the duplicate editors.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue Mar 20, 2023
Closed
4 tasks
kittaakos pushed a commit that referenced this issue Mar 20, 2023
fix: incorrect editor widget key calculation
3a52bbf 
to avoid duplicate editor tabs when opening a sketch with no previously
saved workbench layout

Closes #1791

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
Copy link
Contributor

There is a PR with the proposed fix. I could not reproduce the bug on my env, but I found the problem and fixed it. Could somebody help verify the change? The PR is #1969, and the documentation on how to help with the beta build is here https://github.com/arduino/arduino-ide/blob/main/docs/contributor-guide/beta-testing.md. Thank you!

kittaakos pushed a commit that referenced this issue Mar 28, 2023
@kittaakos
fix: incorrect editor widget key calculation
e4beb03 
to avoid duplicate editor tabs when opening a sketch with no previously
saved workbench layout

Closes #1791

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect editor widget key calculation arduino/arduino-ide
9 participants
@kittaakos @FernandoGarcia @per1234 @jrobert-gh @ChariseWalraven @roboter-basteln @GaryInSanDiego @sterretjeToo @RocketmanJMP