fix: incorrect editor widget key calculation #1969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers, please also see #1970 and #1971 before checking this PR.
Motivation
Avoid duplicate editor tabs when opening a sketch with no previously saved workbench layout.
Change description
This PR fixes the incorrect widget key calculation. Two different widget keys have been calculated for the same resource. For example, this forum post contains the log files and the widget layout. This is an extract that contains the relevant part:
Two code editor widget IDs exist for the same resource:
file:///c%3A/Users/Wim/Documents/Arduino/MaxMSP/double2float/double2float.0.1/double2float.0.1.ino
, but thecounter
which is unused by IDE2, are different.Other information
Closes #1791
Reviewer checklist