Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list view filtering when opening the view #1748

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: list view filtering when opening the view #1748

merged 1 commit into from
Dec 8, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

Fix the search options behavior of the library and boards manager widget when programmatically opening them.

Change description

  • When the widget is opened the first time with any search options, the widget might miss the refresh event as it does not happen at instantiation time. This PR ensures that all list widget refresh events wait until the React component is rendered and is visible in the UI.
  • This change also ensures that the debounced search will run with the most recent search options by setting the trailing property of the debounced function to true.

Other information

Closes #1740

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: list view filtering when opening the view
4ad883d 
When the widget is opened the first time with any search options,
the widget might miss the refresh event as it does not happen at
instantiation time. This PR ensures that all list widget refresh
events wait until the React component is rendered and is visible
in the UI.

This change also ensures that the debounced search will run with
the most recent search options by setting the `trailing` property
of the debounced function to `true`.

Closes #1740

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 7, 2022
per1234
per1234 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1740

Thanks Akos!

@kittaakos kittaakos merged commit f8c01e3 into main Dec 8, 2022
@kittaakos kittaakos deleted the #1740 branch December 8, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@francescospissu francescospissu Awaiting requested review from francescospissu

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @per1234