-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Updatable" filter not set in Boards/Library Manager during "INSTALL MANUALLY" operation if other view open in side panel #1740
Comments
It's working as expected on macOS with 2.0.3. I give it a try on Windows. 1740.mp4 |
It's also working on my Windows env with 2.0.3. 1740_win.mp41740_002_win.mp41740_003_win.mp4 |
Are there any exceptions in the DevTools console? |
Hi @kittaakos. You forgot to do step 2 in the instructions:
A required condition is that another view is previously open in the Side Panel. |
When the widget is opened the first time with any search options, the widget might miss the refresh event as it does not happen at instantiation time. This PR ensures that all list widget refresh events wait until the React component is rendered and is visible in the UI. This change also ensures that the debounced search will run with the most recent search options by setting the `trailing` property of the debounced function to `true`. Closes #1740 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Thank you for the help 🙏
It turned out that the key point was the new sketch and that the lib manager view was not yet opened in IDE2. There was a race condition. |
When the widget is opened the first time with any search options, the widget might miss the refresh event as it does not happen at instantiation time. This PR ensures that all list widget refresh events wait until the React component is rendered and is visible in the UI. This change also ensures that the debounced search will run with the most recent search options by setting the `trailing` property of the debounced function to `true`. Closes #1740 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Yes, it did, but you're using |
Thanks, Note: we are probably in completely different time zones, and when I posted that last response, it was on the morning of the 8th. Thanks |
Describe the problem
Arduino IDE automatically checks for available updates to boards platforms and libraries installed via Boards Manager and Library Manager. If an update is available, a notification dialog appears with the following options:
"INSTALL MANUALLY" opens the Boards Manager or Library Manager view with the "Type" filter set to "Updatable". This allows the user to evaluate the available updates and install them selectively.
If another view was already open in the Side Panel, the "Type" filter is left set to the default "All" when the Boards Manager or Library Manager view is opened.
🐛 "INSTALL MANUALLY" will not provide the user with a convenient path to update dependencies.
To reproduce
Set up
An outdated version of a library is installed in order to trigger the update offer dialog:
arduinocloudthing
ⓘ This is just an arbitrarily selected library with no special significance.
Demo
ⓘ This is done to ensure the Library Manager view has the default "Type" filter setting.
🐛 The Library Manager view opens with the "Type" filter set to "All":
Expected behavior
The "Type" filter is always set to "Updatable" when the "Library Manager" view is opened via the "INSTALL MANUALLY" button of the platform update offer dialog.
Arduino IDE version
2.0.3
Operating system
Windows
Operating system version
10
Additional context
I bisected the introduction of the bug to ac9cce1 / #1662 (does not occur when using the build for the previous commit 3ad6609 or older).
The "Arduino: Check for Arduino Updates" command palette command was used in the demo as a convenient way to trigger the update notification. The bug also affects the more commonly used update notification on IDE startup.
I used the technique of manually opening a view in the side panel in the demo in order to make it as simple as possible. However, the fault also occurs in the more likely use cases when the panel was open for other reasons, such as:
The fault also occurs when opening the view with filter configured via a
librarymanager
/boardsmanager
link under the same conditions.For example:
Originally reported by @KurtE at https://forum.arduino.cc/t/arduino-2-0-3-update-boards/1061726
Issue checklist
The text was updated successfully, but these errors were encountered: